Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more logging for unexpected status codes. #1817

Closed
wants to merge 1 commit into from

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented May 29, 2024

This adds some more logging in the saga to determine why diffing is not working as expected. For the cargo milestoning, all I see in the logs is:

Retrying after 0 seconds, remaining attepts 2
Retrying after 0 seconds, remaining attepts 1
Retrying after 0 seconds, remaining attepts 0

and then nothing. My theory is that it is returning some unexpected status code. The retry logic checks for !is_success() which only checks for codes 2xx, and then error reporting code only checks for error_for_status_ref, which is only 4xx and 5xx. My guess is that some other status code is slipping through? I'm really shooting in the dark since I can't reproduce the issue locally.

@ehuss
Copy link
Contributor Author

ehuss commented Jun 2, 2024

I'm going to close since I'm pretty confident that #1819 will resolve this.

@ehuss ehuss closed this Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant