Fix filename conflict #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@levkk Very Very Much Appreciated! I will get this merged right away, and once again thank you very much for your contribution! I am always saddened when changes break functionality, and appreciate your quick fix for getting our project up and going again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #137
I'm honestly not sure what in 0.8.1 caused this issue to surface. Something around when template files are compiled maybe? It was synchronous before? Anyway... This works. Tested it on our project that has probably 30+ templates, many of which have the same file name.
Template filenames will now be gibberish mostly, but they weren't really useful in large projects anyway, since in our case they all started with
same-file-name-as-everywhere-else-<hash>. Suggestions welcome here, maybe we could reproduce the same folder structure in thebuilddirectory as we have insrc? Surely we can't name output files after the absolute path of the source file since we'll hit a filesystem filename size limit quickly. Thinking out loud. Currently, I added a comment into the generated file explaining where the source code of the template came from.