Fix parsing of comments in parse/1 (#141)

Closes #121
rusterlium · Mar 23, 2024 · 515daa0 · 515daa0
1 parent af4791f
commit 515daa0
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/native/html5ever_nif/src/flat_dom.rs b/native/html5ever_nif/src/flat_dom.rs
@@ -583,7 +583,9 @@ pub fn flat_sink_to_rec_term<'a>(
                 NodeData::Text { contents } => {
                     term = StrTendrilWrapper(contents).encode(env);
                 }
-                NodeData::Comment { .. } => continue,
+                NodeData::Comment { contents } => {
+                    term = (atoms::comment(), StrTendrilWrapper(contents)).encode(env);
+                }
                 _ => unimplemented!(""),
             }
 

diff --git a/test/html5ever_test.exs b/test/html5ever_test.exs
@@ -8,9 +8,17 @@ defmodule Html5everTest do
   end
 
   test "parse basic html" do
-    html = "<html><head></head><body></body></html>"
+    html = "<html><head></head><body><h1>Hello</h1><!-- my comment --></body></html>"
 
-    assert Html5ever.parse(html) == {:ok, [{"html", [], [{"head", [], []}, {"body", [], []}]}]}
+    assert Html5ever.parse(html) ==
+             {:ok,
+              [
+                {"html", [],
+                 [
+                   {"head", [], []},
+                   {"body", [], [{"h1", [], ["Hello"]}, {:comment, " my comment "}]}
+                 ]}
+              ]}
   end
 
   test "does not parse with not valid UTF8 binary" do