Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer partial success to failure #126

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Prefer partial success to failure #126

merged 3 commits into from
Aug 28, 2024

Commits on Aug 20, 2024

  1. Adjust error wording when loading missing files

    ```shell
    $ SSL_CERT_FILE="notexist" target/debug/examples/google
    thread 'main' panicked at examples/google.rs:7:58:
    could not load platform certs: Custom { kind: NotFound, error: "could not load certs from dir notexist: No such file or directory (os error 2)" }
    ```
    
    Note "from dir notexist".  In this case `path.is_file()` is false
    (because it doesn't exist) but that doesn't imply it was being
    read as a directory.
    ctz committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    07c0409 View commit details
    Browse the repository at this point in the history
  2. Prefer partial success to failure

    If we read some certs from a file, but fail to read some from
    a directory (or vv.) then return what we have.
    
    This is good because it restores the crate's previous behaviour.
    It also matches what (for example) golang crypto.x509 does.
    
    This is bad because it hides a failure, which would be confusing
    if a user relied on reading from _both_ a file and directory at
    the same time.  Would someone do that?  The follow commit steps
    towards ameliorating this, slightly.
    ctz committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    a16c8fe View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Prepare 0.7.3

    ctz committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    c2be86c View commit details
    Browse the repository at this point in the history