Add Gamepad vibrationActuator API to web-sys #4098
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
requested changes
Sep 7, 2024
The API that currently exists in the repo has been deprecated and the new API has been added. This allows gamepads to be rumbled Spec: https://w3c.github.io/gamepad/ More details: rustwasm#4089
brettchalupa
force-pushed
the
gamepads-vibrationActuator
branch
from
9718a4d
to
0296a06
Compare
|
@daxpedda thanks for the guidance! I just pushed up a new commit with that change and addressed a merge conflict with the |
daxpedda
requested changes
Sep 16, 2024
Comment on lines
+37
to
+42
| interface GamepadHapticActuator | ||
| { | ||
| [RustDeprecated] | ||
| readonly attribute GamepadHapticActuatorType type; | ||
| [Throws, NewObject, RustDeprecated] | ||
| Promise<boolean> pulse(double value, double duration); |
There was a problem hiding this comment.
Already stabilized APIs can't simply be made unstable, this would be a breaking change.
Comment on lines
+11
to
+14
| [RustDeprecated] | ||
| enum GamepadHapticActuatorType { | ||
| "vibration" | ||
| }; |
There was a problem hiding this comment.
Same as before, this can't be made unstable without a breaking change anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API that currently exists in the repo has been deprecated and the
new API has been added.
This allows gamepads to be rumbled.
I tried to follow the instructions in https://github.com/rustwasm/wasm-bindgen/tree/main/crates/web-sys#how-to-add-an-interface as best as I could.
Spec: https://w3c.github.io/gamepad/
More details: #4089
It's not entirely clear to me how to best test this out, but I'm happy to if anyone's able to provide a little guidance. Thanks!