Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't overwrite an existing .gitignore file #984

Open
sinking-point opened this issue Mar 3, 2021 · 0 comments · May be fixed by #985 or #1408
Open

Don't overwrite an existing .gitignore file #984

sinking-point opened this issue Mar 3, 2021 · 0 comments · May be fixed by #985 or #1408

Comments

@sinking-point
Copy link

If a developer has a custom .gitignore in place, it is unexpected for wasm-pack to overwrite it. wasm-pack should check for an existing .gitignore before writing a new one. Currently, if a developer wants a custom .gitignore, they have to reset it every time they run wasm-pack.

Implementing this makes it no harder for developers who want the default .gitignore. They just have to leave it alone after it's generated.
@sinking-point sinking-point linked a pull request Mar 4, 2021 that will close this issue
Open
@mrothNET mrothNET linked a pull request Jul 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@sinking-point