Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create .gitignore in pkg directory #1408

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrothNET
Copy link

@mrothNET mrothNET commented Jul 6, 2024

Closes #728
Closes #984,
Closes #909
Closes #999.
Supersedes #1131, #985

Problematic Behaviour

Currently, wasm-pack generates a .gitignore file in the pkg directory during each build.

Suggested Solution

This PR proposes removing the automatic creation of the .gitignore file without introducing a replacement.

Justification

While many tools generate an appropriate .gitignore during project initialization, it’s relatively uncommon (in my experience) for build tools, like compilers, to create .gitignore files during a build.

Moreover, this behavior has led to several issues, as outlined in the following requests:

This PR aims to remove the generation of the problematic .gitignore file, addressing and potentially superseding these other PRs:

Changes made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant