Docs fixes #1143
Merged
Docs fixes #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helixbass
commented
May 26, 2022
| @@ -99,7 +99,7 @@ wasm-pack build --target nodejs | |||
|
|
|||
| ## Scope | |||
|
|
|||
| The init command also accepts an optional `--scope` argument. This will scope | |||
| The `build` command also accepts an optional `--scope` argument. This will scope | |||
There was a problem hiding this comment.
I didn't test that you can actually pass --scope to wasm-pack build but this would seem to be the correct change here (to be symmetrical with other stuff on this page and to match the example command below)
| @@ -12,14 +12,14 @@ You'll also want to check out the contributing [guidelines]. | |||
|
|
|||
| ## 🏃♀️ Up and Running | |||
|
|
|||
| 1. fork and clone this repository | |||
| 1. fork and clone the `rustwasm/wasm-pack` repository | |||
There was a problem hiding this comment.
When reading at https://rustwasm.github.io/docs/wasm-pack/ it wasn't self-evident what "this repository" was
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just includes a couple small fixes (typos/grammar/etc) that I noticed as I was reading the wasm-pack docs