Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark snippets and the bundler target's main file as having side effects #1224

Merged
merged 1 commit into from
Mar 19, 2023
Merged

Mark snippets and the bundler target's main file as having side effects #1224

merged 1 commit into from
Mar 19, 2023

Commits on Feb 5, 2023

  1. Mark snippets and the bundler target's main file as having side effects 

    This is a less extreme version of rustwasm#1208, which only marks snippets and the main file on the bundler target as having side effects instead of all files.

This means that the shim file which contains the vast majority of the JS code is still properly marked as having no side effects, allowing bundlers to get rid of things like unused `new TextEncoder` calls which could theoretically have side effects but don't.

Fixes rustwasm#972.
    @Liamolucko
    Liamolucko committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    ad17780 View commit details
    Browse the repository at this point in the history