support no-modules #327
Merged
support no-modules #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleygwilliams
changed the title
ashleygwilliams
force-pushed
the
no-modules-plz-k-thx
branch
from
ca37bb2
to
2f88175
Compare
ashleygwilliams
force-pushed
the
no-modules-plz-k-thx
branch
from
2f88175
to
d79349e
Compare
fitzgen
reviewed
Sep 21, 2018
| @@ -136,6 +136,7 @@ pub fn wasm_bindgen_build( | |||
| }; | |||
| let target_arg = match target { | |||
| "nodejs" => "--nodejs", | |||
| "no-modules" => "--no-modules", | |||
There was a problem hiding this comment.
Not in this PR, but as a follow up issue, this seems like a good candidate for an enum with FromStr and Display impls like how we do with BuildMode and Access
There was a problem hiding this comment.
yeah i was thinking about this when i ran into it, i'll file an issue for a refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #317
note:
this PR puts the js file generated by bindgen in the
browserkey inpackage.jsonand includes it infiles. i am not sure this is the right call- so if folks could weigh in that would be excellent.