fix(exe): wasm-pack-init (1).exe should work #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleygwilliams
added
needs tests
alexcrichton
approved these changes
Feb 22, 2019
There was a problem hiding this comment.
This looks fine by me, I think it's not so much security implications but moreso just making sure we don't accidentally try to install when we shouldn't, but this should cover that.
IIRC there's not any tests already for the installer, so it's probably to just manually verify this
|
@fitzgen or @alexcrichton do either of you have access to a windows machine to manually test this? unfortunately mine is in Austin and i am not. |
|
I, unfortunately, do not |
|
Sorry :( |
|
@ashleygwilliams I have Windows 10, I'll try and reproduce the issue (and verify the fix). |
|
thank you so much @Pauan i really appreciate it! i was able to reproduce the error on my machine when it was originally reported |
Pauan
approved these changes
Feb 28, 2019
|
thank you so much @Pauan !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔕 do no merge 🔕
fixes #518
@alexcrichton how should we test this? (if at all?) are there security implications for not doing the exact match that i'm not thinking of?