Added support for --out-name flag #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ibaryshnikov tests and |
ashleygwilliams
added
needs tests
|
@ashleygwilliams I've added tests |
docs/src/commands/build.md
Outdated
| @@ -32,6 +32,16 @@ wasm-pack build --out-dir out | |||
| The above command will put your build artifacts in a directory called `out`, instead | |||
| of the default `pkg`. | |||
|
|
|||
| ## Output file names | |||
There was a problem hiding this comment.
We might add some more info on exactly what files are outputted and what the names by default are and what parts of the name change when you use this command.
There was a problem hiding this comment.
Have no idea how to choose the title here ((
There was a problem hiding this comment.
@ibaryshnikov maybe "Generated file names"?
There was a problem hiding this comment.
@ashleygwilliams thank you!
ashleygwilliams
added
waiting on response
and removed
needs review
needs tests
ashleygwilliams
approved these changes
Mar 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #596
Should I also add tests for this feature?