Remove dirs dependency (unmaintained), update all dependencies #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran `cargo upgrade` (cargo-edit crate) to update all dependencies
|
@ashleygwilliams Am I being waited upon for the next step of the process? |
|
hi @brightly-salty! no you are not. i have, unfortunately realized that our CI is broken (for multiple reasons), so it's hard to trust tests are passing. i'll merge this now, but it will probably take a second before it will be released. i did quit my job yesterday so i do have some extra time and should hopefully be able to get to it. i do assure you i have not forgotten and that i appreciate you handling this for us! |
|
@brightly-salty could you update this PR to just update the single dependency? I'm going to need to do other work for the other dependencies and I would prefer not hold up this PR |
This reverts commit 87b9a7d.
ashleygwilliams
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally tried to replace dirs with dirs-next. Fixes #943 It turned out that dirs was an unused dependency of wasm-pack.
I ran
cargo upgrade(cargo-edit crate) to update all dependencies andcargo udeps(cargo-udeps) to find any more unused dependencies.Now all dependencies are current and all dependencies are used.