Expander: skip pin normalization calls.

rwaldron · Jun 18, 2015 · b63910c · b63910c
1 parent 59a6332
commit b63910c
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 4 deletions.
diff --git a/lib/board.js b/lib/board.js
@@ -774,10 +774,12 @@ Board.Component = function(opts, componentOpts) {
     }
   }
 
-  // Pin or Pins address(es)
-  opts = Board.Pins.normalize(opts, this.board);
   componentOpts = Board.Component.initialization(componentOpts);
 
+  if (componentOpts.normalizePin) {
+    opts = Board.Pins.normalize(opts, this.board);
+  }
+
   var requesting = [];
 
   if (typeof opts.pins !== "undefined") {
@@ -901,7 +903,8 @@ Board.Component = function(opts, componentOpts) {
 
 Board.Component.initialization = function(opts) {
   var defaults = {
-    requestPin: true
+    requestPin: true,
+    normalizePin: true
   };
 
   return Object.assign({}, defaults, opts);

diff --git a/lib/expander.js b/lib/expander.js
@@ -814,7 +814,7 @@ function Expander(opts) {
   }
 
   Board.Component.call(
-    this, opts = Board.Options(opts)
+    this, opts = Board.Options(opts), { normalizePin: false }
   );
 
   if (typeof opts.controller === "undefined" && controllerValue) {

diff --git a/test/expander.js b/test/expander.js
@@ -82,6 +82,27 @@ exports["Expander"] = {
     test.done();
   },
 
+  skipsPinNormalizationCall: function(test) {
+    test.expect(6);
+
+    this.normalize = sinon.spy(Board.Pins, "normalize");
+
+    [
+      "MCP23017",
+      "MCP23008",
+      "PCF8574",
+      "PCF8574A",
+      "PCF8575",
+      "PCA9685",
+    ].forEach(function(controller) {
+      new Expander(controller);
+
+      test.equal(this.normalize.called, false);
+    }, this);
+
+    test.done();
+  },
+
   noController: function(test) {
     test.expect(1);