Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bogus null arguments from emit(event, ...args) #561

Closed
rwaldron opened this issue Dec 30, 2014 · 5 comments
Closed

Remove bogus null arguments from emit(event, ...args) #561

rwaldron opened this issue Dec 30, 2014 · 5 comments
Assignees
@rwaldron

Comments

@rwaldron
Copy link
Owner

Per discussion in #553
@rwaldron
Copy link
Owner Author

rwaldron commented Jan 5, 2015

@dtex @BrianGenisio

I started working on this and quickly discovered that I'm to blame for a lot of inconsistency :( Getting rid of the bogus error arg is easy, but then there's another issue: the actual data arg—this is all over the place. I'll do the removal in one patch, but we need to have a conversation about the data arg.

@rwaldron
Copy link
Owner Author

rwaldron commented Jan 5, 2015

Also, once this lands, we'll be v0.9.0-beta

@rwaldron rwaldron mentioned this issue Jan 5, 2015
Closed
@rwaldron rwaldron added the 0.9.0 label Jan 5, 2015
@rwaldron rwaldron self-assigned this Jan 5, 2015
rwaldron added a commit that referenced this issue Jan 5, 2015
@rwaldron
Remove bogus null arguments from emitters. Fixes gh-561
038c92f
@rwaldron
Copy link
Owner Author

rwaldron commented Jan 5, 2015

Affects:

  • Accelerometer
  • Gyro
  • IR
  • Joystick
  • Motor
  • Ping
  • Pir
  • ReflectanceArray
  • Sensor
  • Sonar
  • Temperature
  • Wii

rwaldron added a commit that referenced this issue Jan 5, 2015
@rwaldron
Remove bogus null arguments from emitters. Fixes gh-561
6c76236
rwaldron added a commit that referenced this issue Jan 5, 2015
@rwaldron
Remove bogus null arguments from emitters. Fixes gh-561
74342d6
rwaldron added a commit that referenced this issue Jan 7, 2015
@rwaldron
Remove bogus null arguments from emitters. Fixes gh-561
3e0ebd4
rwaldron added a commit that referenced this issue Jan 9, 2015
@rwaldron
Remove bogus null arguments from emitters. Fixes gh-561
601b4af
rwaldron added a commit that referenced this issue Jan 9, 2015
@rwaldron
Remove bogus null arguments from emitters. Fixes gh-561
b6ef136
rwaldron added a commit that referenced this issue Jan 14, 2015
@rwaldron
Remove bogus null arguments from emitters. Fixes gh-561
080340d
rwaldron added a commit that referenced this issue Jan 15, 2015
@rwaldron
Remove bogus null arguments from emitters. Fixes gh-561
fd8c5dd
rwaldron added a commit that referenced this issue Jan 15, 2015
@rwaldron
Remove bogus null arguments from emitters. Fixes gh-561
6e05c3e
rwaldron added a commit that referenced this issue Jan 16, 2015
@rwaldron
Remove bogus null arguments from emitters. Fixes gh-561
ea9ba99
rwaldron added a commit that referenced this issue Jan 20, 2015
@rwaldron
Remove bogus null arguments from emitters. Fixes gh-561
71bdf53
rwaldron added a commit that referenced this issue Jan 20, 2015
@rwaldron
Remove bogus null arguments from emitters. Fixes gh-561
dec079d
rwaldron added a commit that referenced this issue Jan 26, 2015
@rwaldron
Remove bogus null arguments from emitters. Fixes gh-561
9cafc9b
rwaldron added a commit that referenced this issue Jan 26, 2015
@rwaldron
Remove bogus null arguments from emitters. Fixes gh-561
3b653b0
rwaldron added a commit that referenced this issue Mar 18, 2015
@rwaldron
Remove bogus null arguments from emitters. Fixes gh-561
0086551
rwaldron added a commit that referenced this issue Mar 18, 2015
@rwaldron
Remove bogus null arguments from emitters. Fixes gh-561
250d542
rwaldron added a commit that referenced this issue Mar 24, 2015
@rwaldron
Remove bogus null arguments from emitters. Fixes gh-561
d1c96e5
rwaldron added a commit that referenced this issue Mar 24, 2015
@rwaldron
Remove bogus null arguments from emitters. Fixes gh-561
6130d80
rwaldron added a commit that referenced this issue Mar 24, 2015
@rwaldron
Remove bogus null arguments from emitters. Fixes gh-561
c141f96
@scottgonzalez
Copy link
Contributor

Since there doesn't seem to be an existing reference to the PR: #667.

@rwaldron
Copy link
Owner Author

Nothing wrong with explicit link, but Github auto links it:

rwaldron added a commit that referenced this issue Apr 30, 2015
@rwaldron
Remove bogus null arguments from emitters. Fixes gh-561
2b4cf6f
rwaldron added a commit that referenced this issue May 5, 2015
@rwaldron
Remove bogus null arguments from emitters. Fixes gh-561
e4b05ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwaldron rwaldron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwaldron @scottgonzalez