Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/board.js is failing but we never see the error #828

Closed
dtex opened this issue Jun 18, 2015 · 1 comment
Closed

test/board.js is failing but we never see the error #828

dtex opened this issue Jun 18, 2015 · 1 comment
Labels
Tests

Comments

@dtex
Copy link
Collaborator

dtex commented Jun 18, 2015

The board created at https://github.com/rwaldron/johnny-five/blob/master/test/board.js#L43-L47 is trying to use Firmata instead of mockFirmata. This results in a timeout that we weren't seeing because the tests completed before it was thrown. Now that extended tests are growing we are seeing the timeout.
@dtex dtex added the Tests label Jun 18, 2015
rwaldron referenced this issue Jun 18, 2015
@Resseguie
emit errors instead of calling process.exit()
2fd7f9c 
Improvement to #520 error handling
rwaldron added a commit that referenced this issue Jun 18, 2015
@rwaldron
Ensure MockFirmata is used when IS_TEST_MODE=true. Fixes gh-828
50600d0
@dtex dtex mentioned this issue Jun 18, 2015
Closed
rwaldron added a commit that referenced this issue Jul 7, 2015
@rwaldron
Merge pull request #833 from rwaldron/828
3127ea2 
Ensure MockFirmata is used when IS_TEST_MODE=true. Fixes gh-828
@dtex
Copy link
Collaborator Author

dtex commented Jul 8, 2015

Ugh, I think there is another one timing out somewhere. I'll find it and open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dtex