Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #4 #5

Merged
merged 1 commit into from
Dec 19, 2018
Merged

fixes #4 #5

merged 1 commit into from
Dec 19, 2018

Conversation

activescott
Copy link
Contributor

With this fix, on the same project mentioned in issue #4, the output becomes the following:

$ serverless deploy
Serverless: Packaging service...
Serverless: Excluding development dependencies...
Serverless: Uploading CloudFormation file to S3...
Serverless: Uploading artifacts...
Serverless: Uploading service .zip file to S3 (133.08 KB)...
Serverless: Validating template...
Serverless: Updating Stack...
Serverless: Checking Stack update progress...
..........
Serverless: Stack update finished...
Serverless: Setting up content handling in AWS API Gateway (takes ~1 min)...
Serverless: Deploying content handling updates to AWS API Gateway...
Serverless: AWS API Gateway Deployed
Service Information
service: demo-option2-contentHandling
stage: dev
region: us-east-1
stack: demo-option2-contentHandling-dev
api keys:
  None
endpoints:
  GET - https://vcnes1h9b6.execute-api.us-east-1.amazonaws.com/dev/binary/{pathvar+}
functions:
  returnbits: demo-option2-contentHandling-dev-returnbits
layers:
  None
Serverless: Removing old service artifacts from S3...
✨  Done in 88.09s.

Note the Serverless: Deploying content handling updates to AWS API Gateway... line... A check with the AWS CLI reveals that contentHandling was set as expected.

@ryanmurakami
Copy link
Owner

This is awesome, thanks for opening a PR. I'll take a look over the holidays.

@ryanmurakami
Copy link
Owner

nm, looks good.

@ryanmurakami ryanmurakami merged commit 18894cc into ryanmurakami:master Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants