Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing prop-types dependency #849

Closed
vorant94 opened this issue Jul 20, 2024 · 2 comments
Closed

Consider removing prop-types dependency #849

vorant94 opened this issue Jul 20, 2024 · 2 comments

Comments

@vorant94
Copy link

Describe the issue and the actual behavior

prop-types are marked as deprecated as of 2017 and in the upcoming React 19 validation failure will start to be silently ignored. Official React docs suggest replacing it with TypeScript interface to still benefit from build-time checks and reduce the overall bundle size.

https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-proptypes-and-defaultprops

Describe the expected behavior

Please consider removing this lib from the list of dependencies. If you are OK with it, I'll be glad to contribute the fix

@s-yadav
Copy link
Owner

s-yadav commented Aug 25, 2024

Actually we can remove it as internall we are no longer using it.

@s-yadav
Copy link
Owner

s-yadav commented Aug 25, 2024

Fixed on 5.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants