Fix decimal scale issue #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhil-varma
changed the title
s-yadav
reviewed
Mar 14, 2021
s-yadav
approved these changes
Mar 15, 2021
This was referenced Mar 15, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue/change
This PR fixes decimal scale issue. Ref issue linked in this PR
Add CodeSandbox link to illustrate the issue (If applicable)
https://codesandbox.io/s/material-demo-forked-6jcgb?file=/demo.js:0-2546
Describe specs for failing cases if this is an issue (If applicable)
When a value like
123.15is passed, the final value returned and assigned to the input is123.14. This is happening because of thetoFixedmethod causing a floating point issue.Describe the changes proposed/implemented in this PR
This fix ensure that the scale is capped only when the decimal value overshoots the scale value
Link Github issue if this PR solved an existing issue
Fix for : #495
Example usage (If applicable)
N/A
Screenshot (If applicable)
N/A
Please check which browsers were used for testing