fix: pass currentTarget to onFocus #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar-girhepunje
approved these changes
Nov 29, 2023
|
Hey @s-yadav - I'm gently pinging you for when you get a chance to review this PR. Thank you! |
|
@s-yadav 👋 when you get a chance, this would be much appreciated! |
|
Hey @csantos1113 , was little occupied with some personal things for last 4 months, so didn't check. |
|
Never mind I added test, and merging this. |
s-yadav
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue/change
This change is based on https://stackoverflow.com/a/66086044
currentTarget: only exists if used right from theonFocusevent; but we get currentTarget null becauseonFocus(e)is called within a timeout.References: