introduce several bugfixes, new APIs #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugenebokhan
reviewed
Aug 9, 2020
Alloy/Encoders/TextureCopy.swift
Outdated
| at: 1) | ||
|
|
||
| if self.deviceSupportsNonuniformThreadgroups { | ||
| encoder.dispatch2d(state: self.pipelineState, | ||
| exactly: gridSize) | ||
| } else { | ||
| encoder.set(SIMD2<UInt16>(x: .init(gridSize.width), | ||
| encoder.setValue(SIMD2<UInt16>(x: .init(gridSize.width), | ||
| y: .init(gridSize.height)), |
| @@ -91,7 +91,7 @@ public final class MTLContext { | |||
| if | |||
| isSRGB == nil, | |||
| let colorSpace = image.colorSpace, | |||
| colorSpace.name == CGColorSpace.sRGB | |||
| colorSpace.name == CGColorSpace.linearSRGB | |||
There was a problem hiding this comment.
is there going to be visible difference?
s1ddok
added a commit
that referenced
this pull request
Aug 26, 2020
* remove warnings * style fixes * update version * introduce several bugfixes, new APIs (#103) * introduce several bugfixes, new APIs * fix alignment * Squashed commit of the following: fix TextureWeightedMix (#104) Add Texture Mix (#100) * add texture mix * naming * update version * update encoder * replace mask reading with mask sampling * fix shared memory size * fix typo in float conversion * Texture Mask Inversion (#106) * add inversion to TextureMask * remove redundant annotation * RGBA to YCbCr (#105) * rgba to ycbcr * update rgba to ycbcr * migrate to gather * fixes * use to matrix multiplication * use matrix transpose * simplify mean calculation Co-authored-by: Andrey Volodin <siddok@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.