Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot override muted param with Vimeo video #1524

Closed
dev-newvisibility opened this issue Jul 20, 2023 · 2 comments · Fixed by #1526
Closed

Cannot override muted param with Vimeo video #1524

dev-newvisibility opened this issue Jul 20, 2023 · 2 comments · Fixed by #1526
Labels

Comments

@dev-newvisibility
Copy link
Contributor

The comment says that Vimeo gives priority to the last parameter when duplicates are found, but this doesn't seem to be true anymore.

https://player.vimeo.com/video/347119375?muted=0&muted=1
https://player.vimeo.com/video/347119375?muted=1&muted=0

// For vimeo last params gets priority if duplicates found

dev-newvisibility added a commit to dev-newvisibility/lightGallery that referenced this issue Jul 24, 2023
@mattparlane
Copy link

I just stumbled across this issue, it also affects the autoplay parameter. Any chance of getting this PR merged?

Copy link

stale bot commented Nov 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the v1 label Nov 18, 2023
@stale stale bot closed this as completed Nov 25, 2023
sachinchoolur pushed a commit that referenced this issue Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants