Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor inline styles in thumbnail plugin for CSP compatibility #1565

Merged
merged 2 commits into from
Feb 10, 2024
Merged

Conversation

ajuzp5
Copy link
Contributor

@ajuzp5 ajuzp5 commented Nov 24, 2023

Problem:

If we add Content-Security-Policy in the of our HTML file currently restricts inline styles with the directive style-src 'self';. This leads to a scenario where thumbnail images that rely on inline styling do not render correctly.

Visual Proof of Issue:

Screenshot 2023-11-24 at 3 26 37 PM

Copy link

stale bot commented Jan 25, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the v1 label Jan 25, 2024
@stale stale bot closed this Feb 2, 2024
@sachinchoolur sachinchoolur reopened this Feb 10, 2024
@stale stale bot removed the v1 label Feb 10, 2024
@sachinchoolur sachinchoolur merged commit b350f44 into sachinchoolur:master Feb 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants