Skip to content

Commit

Permalink
Cornerstone update 6.0.0 (#51)
Browse files Browse the repository at this point in the history
* BCTHEME-210 Carousel hidden when one or more of its images not found (bigcommerce#1816)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* BCTHEME-214 Wishlist first option has no bottom outline when in focus (bigcommerce#1825)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-217 Product link has incorrect voice over focus on Cart Page (bigcommerce#1830)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-172 Card content truncated on zooming browser to 400% (bigcommerce#1803)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* BCTHEME-185 Sort By dropdowns need visual focus border (bigcommerce#1833)

* BCTHEME-188 Product cards should link to products (bigcommerce#1842)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* BCTHEME-184 Options on change modal need focus border (bigcommerce#1839)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* BCTHEME-199 Zooming and scaling must not be disabled (bigcommerce#1843)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* BCTHEME-202 Notification of number of products not announced (bigcommerce#1845)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* BCTHEME-190 Content should not scroll in two directions when zoomed (bigcommerce#1853)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront)BCTHEME-205: add filter reset announcement (bigcommerce#1858)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront) BCTHEME-206: add announcement fot filtered result on Shop-by-price (bigcommerce#1854)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront)BCTHEME-164: fix image in modal for IE11 (bigcommerce#1840)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-279 fix logo displaying (bigcommerce#1865)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront):add to cart notification (bigcommerce#1860)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* BCTHEME-44 Cornerstone quick view (bigcommerce#1857)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-277 Certain Special Characters not rendering under Wishlists (bigcommerce#1873)

* fix(storefront): BCTHEME-219 Social icons not clickable in modal after reopening (bigcommerce#1874)

* fix(storefront): BCTHEME-282 Fix aria-labels for collapsibleFactory elements (bigcommerce#1868)

* BCTHEME-269 Remove layout shifts to improve CLS indicator from Lighthouse performance report (bigcommerce#1869)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-233 Cornerstone - Unable to Compare Products from Recently Viewed Items (bigcommerce#1877)

* feat(storefront): BCTHEME-290 add aria labelwith price for product list item (bigcommerce#1878)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* BCTHEME-209 Search result not notified by screen reader (bigcommerce#1867)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-289 Add aria label with price to Product Grid Item (bigcommerce#1875)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-268 Update carousel images to improve LCP indicator from Lighthouse performance report (bigcommerce#1876)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront): BCTHEME-187 improve localization and add default and fallback messages (bigcommerce#1850)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-297 Cornerstone 4.11.0 - Product Image Carousel Becomes Unresponsive on Product Page (bigcommerce#1879)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* Resolved issues after merging PRs for 4.12 release

* Releasing 4.12.0-rc.1

* Reduce lodash usage in compare-products.js and image-gallery.js

* Releasing 4.12.0-rc.2

* Releasing 4.12.0-rc.3

* Releasing 4.12.0-rc.4

* Upload bundle analysis as part of github action

* feat(search): ES-1590 display error message if search fails

* feat: (STRF-8747) add new stencil config files to .gitignore

* Releasing 4.12.0

* Revert "Releasing 4.12.0"

* feat(storefront): BCTHEME-299 update  changelog for release 4.12

* Releasing 4.12.0

* Updated CHANGELOG.md before 4.12 release

* Reverting cornerstone version to 4.12-rc.4

* Releasing 4.12.0

* Reverting 4.12 changes

* Releasing 4.12.0

* Reverted 4.12 release commit and updated package.json versions

* Releasing 4.12.0

* Revert fix(storefront): BCTHEME-219 Social icons not clickable in modal

* Don't load social icons in quick view

* Bump stencil-utils

* fix(storefront): BCTHEME-305 Price Lists - Price in the cart is not updated when changing currency on mobile

* fix(storefront): BCTHEME-314 ccount >Payment Methods throws Server Error when using Cornerstone theme (bigcommerce#1898)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-315 Write a Review modal cause TypeError (bigcommerce#1899)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* Releasing 4.12.1

* feat(payments): PAYPAL-712 Checkout page - Smart Payment Button styli… (bigcommerce#1866)

feat(payments): PAYPAL-712 Checkout page - Smart Payment Button styling (Cornerstone)

* feat(storefront): BCTHEME-116 move tax field after grand total when tax inclusive (bigcommerce#1903)

* fix(storefront): BCTHEME-105 Cornerstone - Body text size above 14px is cut off on cart shipping dropdowns (bigcommerce#1881)

* feat(storefront): BCTHEME-69 Add tooltips for carousel bullets (buttons) (bigcommerce#1889)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-319 Write a review modal extra executions (bigcommerce#1902) (bigcommerce#1902)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-232 Faceted search filters are hidden from screen readers (bigcommerce#1897)

* fix(storefront): BCTHEME-292 Social icon tooltip displaying should be fixed (bigcommerce#1907)

* BCTHEME-293 Product list item Quick view button is not tabbable (bigcommerce#1900) (bigcommerce#1900)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-273 fix contrast ratio for Skip to Main Content element (bigcommerce#1880)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront): BCTHEME-275 add upsell banner contrast (bigcommerce#1891)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-274 fix contranst ratio for brand name (bigcommerce#1882)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-288 Shoppers are not anchor-linked to reviews on PDPs if product description tabs are enabled (bigcommerce#1883)

* fix(storefront): BCTHEME-308 HTML Entity displayed as is via system/error message on a Storefront (bigcommerce#1888)

* STRF-8769 Moved zoomSize and productSize to the upper level, cause product.js is not availabe on the Quick View (bigcommerce#1884)

* Bump versions of Ruby (bigcommerce#1905)

To fix issue bigcommerce#1904

* Changelog update

* fix(storefront): BCTHEME-104 Selecting product options doesn't update image on PDP in Internet Explorer (bigcommerce#1913)

* fix(storefront): BCTHEME-11 hide product options that are out of stock on cart (bigcommerce#1911)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-301 Header content placed out of the header block on mobile (bigcommerce#1908) (bigcommerce#1908)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-85 “Sort by” dropdown selection not reflected on search results page for News and Information tab (bigcommerce#1910) (bigcommerce#1910)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-86 Cornerstone - Text hover color does not change when Dropdown menu display mode is set to Alternative (bigcommerce#1918) (bigcommerce#1918)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-321 fix social icon tooltip overlaying (bigcommerce#1914)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* Resolving eslint error after merging

* fix(storefront): BCTHEME-30 fix misaligned tooltip for required product option (bigcommerce#1915)

Co-authored-by: yurytut1993 <66325265+yurytut1993@users.noreply.github.com>

* fix(storefront): BCTHEME-87 Product images squashed in Category view in AMP (bigcommerce#1921) (bigcommerce#1921)

* fix(storefront): BCTHEME-313 Parse HTML entities in jsContext (bigcommerce#1917)

* Added Changelog item for BCTHEME-313

* Releasing 5.0.0-rc.1

* feat(payments): PAYPAL-823 Add new banner on the cart page (bigcommerce#1901)

* Releasing 5.0.0-rc.2

* Releasing 5.0.0

* feat(storefront): BCTHEME-304 add pagination for wishlists (bigcommerce#1906)

* fix(storefront): BCTHEME-341 fix placeholder contrast ratio (bigcommerce#1933)

* fix(storefront): BCTHEME-37 Cornerstone - Image Zoom Does Not Work on Internet Explorer (bigcommerce#1923) (bigcommerce#1923)

* feat(storefront): BCTHEME-306 show price range on option selection (bigcommerce#1924)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-16 Cornerstone - loading of thumbnail image delayed on cart page (bigcommerce#1925 (bigcommerce#1925)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-193 fix not being able to change product qty with keyboard multiple times (bigcommerce#1927)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-345 define a main region on pages (bigcommerce#1929)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-346 add announcement for shipping estimator error messages (bigcommerce#1932)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront): BCTHEME-343 No tooltips provided for carousel buttons (bigcommerce#1934) (bigcommerce#1934)

* feature(storefront): Empty cart message not read by screen reader (bigcommerce#1935) (bigcommerce#1935)

* feat(storefront): BCTHEME-344 Carousel buttons do not receive focus (bigcommerce#1937) (bigcommerce#1937)

* fix(storefront): BCTHEME-155 fix recaptcha announcement for hidden content (bigcommerce#1943)

* fix(storefront): BCTHEME-379 fix non-text contrast on add to cart button (bigcommerce#1946)

* fix(storefront): BCTHEME-369 fix announcement on adding to cart by screen reader (bigcommerce#1950)

* feat(storefront): BCTHEME-373 Alt text not provided for ratings (bigcommerce#1949)

* feat(storefront): BCTHEME-78 Add Play/Pause button to carousel (bigcommerce#1944)

* fix(storefront): BCTHEME-366 Error message on PLPs not announced by screen reader (bigcommerce#1956)

* fix(storefront): BCTHEME-361 fix subscription message announcement (bigcommerce#1952)

* feat(payments): PAYPAL-903 Product Page Banners (Cornerstone) - creat… (bigcommerce#1948)

* feat(payments): PAYPAL-903 Product Page Banners (Cornerstone) - create custom price event

* feat(payments): PAYPAL-903 Product Page Banners (Cornerstone) - create custom price event
- CR fixes

Co-authored-by: Alex Saiannyi <67792608+bc-alexsaiannyi@users.noreply.github.com>

* BCTHEME-327: PDP - Empty "Description" is Hiding All Tabs When in Tab View (bigcommerce#1947)

* feat(storefront): BCTHEME-388 Dots on carousel should have similar colours as other slider controls (bigcommerce#1958)

* fix(storefront): BCTHEME-384 When default option is out of stock add to cart button does not populate for in stock options (bigcommerce#1955)

* fix(storefront): BCTHEME-383 Selecting certain option types pushes window view to the bottom of the page (bigcommerce#1959)

* Fixed merge conflict

* STRF-8898 'Show More' gives no additional options when filter clicked (bigcommerce#1945)

* Releasing 5.1.0-rc.1

* BCTHEME-387: Updates Cornerstone variants to meet the updated verticals outlined in BCTHEME-387. (bigcommerce#1962)

Co-authored-by: Dante Muñoz <dante.munoz@c02v90c0htdh.lan>

* Releasing 5.1.0-rc.2

* Releasing 5.1.0

* feat(storefront): STRF-8948 Fix Sort By on Search Page (bigcommerce#1971)

* fix(storefront): BCTHEME-368 fix announcement for shop by price filter selection (bigcommerce#1966)

* fix(storefront): BCTHEME-207 fix focus on sort by (bigcommerce#1964)

* fix(storefront): BCTHEME-385 move a phrase from html to en.json (bigcommerce#1972)

* feat(storefront): BCTHEME-390 Integrate accessibility scripts to product images slider on PDP (bigcommerce#1965)

* fix(storefront): BCTHEME-354 If multiple Pick List Options are applied, customers cannot select 'none' on both (bigcommerce#1975)

* fix(storefront): BCTHEME-356 Required checkbox message blocks the checkbox (bigcommerce#1963)

* Updated Changelog PR link for BCTHEME-212 Fixed review rating icons focus border.

* feat(storefront): BCTHEME-391 Move focus on filter items Modal after show more button was clicked and accessibility refactoring (bigcommerce#1977)

* feat(storefront) BCTHEME-381 add suffient text for swatch option (bigcommerce#1976)

* fix(storefront): BCTHEME-398 Make every product option group id unique (bigcommerce#1979)

* fix(storefront): BCTHEME-264 fix update discount banner on PDP (bigcommerce#1974)

* fix(storefront): BCTHEME-372 Error message not announced automatically (bigcommerce#1983)

* fix(storefront): BCTHEME-400 If product options are not required, the 'None' option will remain selected even if another option is chosen (bigcommerce#1980)

* fix(storefront): BCTHEME-334 Add alt attribute for no image placeholders (bigcommerce#1984)

* fix(storefront): BCTHEME-401 Category pages are creating alt attribute within the span tag (bigcommerce#1987)

* fix(storefront): BCTHEME-362 fix cut off cart button on zooming 400 (bigcommerce#1988)

* Releasing 5.2.0-rc.1

* Releasing 5.2.0

* Reverting 5.2.0 to 5.2.0-rc.1

* Releasing 5.2.0

* Revert "Releasing 5.2.0"

* Releasing 5.2.0

* Revert "Releasing 5.2.0" 2nd time

* Releasing 5.2.0

* feat(storefront): BCTHEME-200 add notifications announcement on carousel change (bigcommerce#1986)

* fix(storefront): BCTHEME-392 fixed line breaks on Dropdown Menu (bigcommerce#1996)

* fix(storefront): BCTHEME-347 Add unique identifiers to product cards (bigcommerce#1999)

* fix(storefront): BCTHEME-409 Update focus trap in Modal (bigcommerce#1998)

* fix(search): ES-2031 add error message for when star search is not availabble in facted search

* feat(search): ES-1590 render error msg for brand page

* fix(search): ES-2031 make search error more generic

* feat(search): ES-2031 add change to changelog

* feat(storefront): BCTHEME-322 add sold-out badges for products on PLP (bigcommerce#2003)

* BCTHEME-426: Insufficient link text for "Read More" links (bigcommerce#2012)

* BCTHEME-422: Announce email field as mandatory (bigcommerce#2011)

* BCTHEME-420: 'Skip to main content' is not visible (bigcommerce#2010)

* fix(storefront): BCTHEME-427 Insufficient button label on cart page (bigcommerce#2013)

* feat(storefront): BCTHEME-231 Add placeholder for failed to load carousel images and update scalability (bigcommerce#2009)

* fix(storefront): BCTHEME-429 Unlabelled edit fields on cart page (bigcommerce#2016)

* fix(storefront): BCTHEME-428 Insufficient link text on cart page (bigcommerce#2014)

* fix(storefront): BCTHEME-424 Alt text should include product name for ratings (bigcommerce#2015)

* fix(storefront): IE11 - Clicking on Search Does Not Display Search Bar (bigcommerce#2017)

* Releasing 5.3.0-rc.1

* Fixing 'Skip to main' content mobile display

* Releasing 5.3.0-rc.2

* Releasing 5.3.0

* Revert Releasing 5.3.0

* Remove AddThis for social sharing, replace with provider sharing links (bigcommerce#1997)

* Updated changelog

* Releasing 5.3.0

* fix(search): ES-2071 removed adding selected filters for price filter since not needed (bigcommerce#2018)

* fix(storefront): BCTHEME-431 remove horizontal scroll on swatch options PDP (bigcommerce#2023)

* fix(search): ES-2138 fixed count showing issue for category facet

* fix(storefront): BCTHEME-349 improve email validation for forms (bigcommerce#2029)

* feat(storefront): BCTHEME-445 replace page builder ssl settings with new global region for html widget (bigcommerce#2026)

* fix(storefront): BCTHEME-447 extend keyboard support for radio buttons (bigcommerce#2028)

* feat(storefront): BCTHEME-446 Improve performance of analyzing homepage carousel image (bigcommerce#2027)

* fix(storefront): BCTHEME-395 Wish List drop down is truncated on product page (bigcommerce#2001)

* fix(storefront): BCTHEME-434 Hamburger Menu Icon missing on Google AMP Pages (bigcommerce#2022)

* fix(storefront): BCTHEME-449 remove main tag duplicates (bigcommerce#2032)

* feat(storefront): BCTHEME-425 Incorrect focus order for product carousels (bigcommerce#2034)

* Releasing 5.4.0-rc.1

* fix(storefront): DEV-426 Fix GitHub workflows for default storefront

* Releasing 5.4.0

* fix(storefront): BCTHEME-325 Apple pay button displaying needs to be fixed (bigcommerce#2043)

* fix(storefront): BCTHEME-457 Update focus tooltip styles contrast to achieve accessibility AA Complaince (bigcommerce#2047)

* Use https:// for schema markup (bigcommerce#2039)

* fix(storefront): BCTHEME-423 Search result on search page not notified by screen reader (bigcommerce#2024)

* feat(payment): PAYPAL-968 added banner widgets to page builder (bigcommerce#2021)

* fix(storefront): bctheme-448 fix multiple swatch options (bigcommerce#2040)

* feat(storefront): BCTHEME-476 Scale focus trap for all modals (bigcommerce#2049)

* Releasing 5.5.0-rc.1

* Releasing 5.5.0

* fix(storefront): BCTHEME-496 Translation Gap: Delete from Cart confirmation popup. (bigcommerce#2065)

* fix(storefront): BCTHEME-512 add translation for invalid quantity value error on cart (bigcommerce#2062)

* fix(storefront): BCTHEME-459 fix product quantity change error (bigcommerce#2052)

* Fix eslint grunt check

* build(deps): bump underscore from 1.12.0 to 1.13.1 (bigcommerce#2053)

* Updated CHANGELOG.md for bigcommerce#2052

* fix(storefront): BCTHEME-514 Translation Gap: Gift Certificate -> Code required message (bigcommerce#2064)

* fix(storefront): BCTHEME-490 Translation Gap: Compare products error message (bigcommerce#2061)

Co-authored-by: yurytut1993 <66325265+yurytut1993@users.noreply.github.com>

* fix(storefront): BCTHEME-492 Translation Gap: Compare page fields (Description, Rating and Availability) (bigcommerce#2059)

* fix(storefront): BCTHEME-479 Logo on AMP Product details page (PDP) does not fit header (bigcommerce#2054)

* fix(storefront): BCTHEME-477 Add to cart button and Wishlist should be on one line on desktop (bigcommerce#2050)

* fix(storefront): BCTHEME-535 Translation Gap: Cart -> Shipping estimator error messages. (bigcommerce#2066)

* fix(storefront): BCTHEME-507 Translation Gap: Account -> Wish List -> Name required message. (bigcommerce#2060)

* fix(storefront): BCTHEME-452 Unable to select 'None' on unrequired Swatch Options (bigcommerce#2068)

* Fix eslint errors in cart.js, shipping-estimator.js and test in cart.spec.js (bigcommerce#2072)

* fix(storefront): STRF-9126 Facebook social share returns an error for blog pages

* fix(storefront): BCTHEME-544 fix potential shift on change options modal on Cart (bigcommerce#2071)

* fix(storefront): BCTHEME-543 Product images in quick view can be squashed (bigcommerce#2075)

* fix(storefront): BCTHEME-601 Enter press on Compare checkbox cause quick view opening (bigcommerce#2074)

* feat(storefront): BCTHEME-608 Translation mechanism for config.json values should be implemented (bigcommerce#2076)

* Update CHANGELOG.md

* Updated CHANGELOG.md for bigcommerce#2024

* Releasing 5.6.0-rc.1

* Add missing quotes for Country and State/Province fields of Shipping Estimator to pass functional tests (bigcommerce#2079)

* Releasing 5.6.0-rc.2

* Releasing 5.6.0

* feat(storefront): BCTHEME-603 Added translations for Consent Manager (bigcommerce#2083)

* feat(storefront): BCTHEME-600 Added translation files for Cornerstone (bigcommerce#2084)

* Releasing 5.7.0

* fix(storefront): BCTHEME-689 Update lang files for some locales (bigcommerce#2086)

* Releasing 5.7.1

* Changelog format changes (bigcommerce#2092)

* add changelog requirements (bigcommerce#2080)

* feat(storefront): BCTHEME-152 Replaced scss-lint with stylelint (bigcommerce#2069)

* fix(storefront): BCTHEME-540 User Account, bug styles in section payment methods (bigcommerce#2085)

* fix(storefront): BCTHEME-511 Remove counter on the Wish Lists tab on Account page (bigcommerce#2087)

* fix(storefront): BCTHEME-532 'undefined' is announced with screen reader while changing Product quantity on PDP (bigcommerce#2094)

* Fix social sharing links for product pages and blog posts (bigcommerce#2082)

* feat(payment): PAYPAL-886 added container setting for spb container (bigcommerce#2041)

* fix(storefront): Reviews pagination navigation buttons reload the whole page and does not open the Reviews tab (bigcommerce#2048)

* Update package-lock.json file (bigcommerce#2097)

* fix(storefront): BCTHEME-606 No navigation back to wishlist tab when you are in a wishlist (bigcommerce#2096)

* Fix minor merge navigation issue

* Fixing merge conflict: BCTHEME-606 (bigcommerce#2100)

* fix(storefront): BCTHEME-686 "Manage Website Data Collection Preferences" phrase is not translatable (bigcommerce#2090)

* feat(storefront): BCTHEME-674 Make Hero Carousel both slide and button clickable when button enabled (bigcommerce#2098)

* fix(storefront): BCTHEME-708 fix wishlist dropdown shift in quickview modal (bigcommerce#2102)

* fix(storefront): BCTHEME-671 Empty email input in newsletter field does not trigger an error (bigcommerce#2101)

* fix(storefront): BCTHEME-547 As a shopper I want to see gift wrapping price in product list the cart. (bigcommerce#2093)

* BCTHEME-693: Update translation mechanism for config.json values (bigcommerce#2089)

* Update translation mechanism for config.json values

* Releasing 6.0.0-rc.1

* Releasing 6.0.0

---------

Co-authored-by: yurytut1993 <66325265+yurytut1993@users.noreply.github.com>
Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>
Co-authored-by: Alex Saiannyi <67792608+bc-alexsaiannyi@users.noreply.github.com>
Co-authored-by: Tymur Biedukhin <tymur.biedukhin@bigcommerce.com>
Co-authored-by: Yurii Zusik <yurii.zusik@bigcommerce.com>
Co-authored-by: sacr3dc0w <mshettles@gmail.com>
Co-authored-by: alex.saiannyi <alexander.saiannyi@bigcommerce.com>
Co-authored-by: Nathan Booker <bookernath@users.noreply.github.com>
Co-authored-by: Kevin Wang <kwang30@gmail.com>
Co-authored-by: MaxGenash <max.henash@bigcommerce.com>
Co-authored-by: David Huynh <david.huynh@bigcommerce.com>
Co-authored-by: Nathan Booker <nathan.booker@bigcommerce.com>
Co-authored-by: Andrii Fetisov <54856617+bc-fetisov@users.noreply.github.com>
Co-authored-by: jairo-bc <68893868+jairo-bc@users.noreply.github.com>
Co-authored-by: Andrew A. Barber <hello@andrewbarber.me>
Co-authored-by: Brian Davenport <bdav87@gmail.com>
Co-authored-by: Olga Lashkul <32959076+helga1507@users.noreply.github.com>
Co-authored-by: Dante Munoz <35115108+DanteMunoz@users.noreply.github.com>
Co-authored-by: Dante Muñoz <dante.munoz@c02v90c0htdh.lan>
Co-authored-by: Nataliya Solyanik <nataliya.solyanik@bigcommerce.com>
Co-authored-by: bc-krishsenthilraj <39140274+bc-krishsenthilraj@users.noreply.github.com>
Co-authored-by: Senthil Krishnasamy <senthil.krishnasamy@bigcommerce.com>
Co-authored-by: Yevhenii Buliuk <82589781+bc-yevhenii-buliuk@users.noreply.github.com>
Co-authored-by: Andrii Vitvitskyi <andrii.vitvitskyi@bigcommerce.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: bc-vlad-dlogush <83779098+bc-vlad-dlogush@users.noreply.github.com>
Co-authored-by: Jairo Panduro <jairo.panduro@bigcommerce.com>
Co-authored-by: Alex Rowley <rowleyaj@gmail.com>
  • Loading branch information
1 parent 944ee58 commit d7f51cb
Show file tree
Hide file tree
Showing 121 changed files with 5,316 additions and 1,907 deletions.
4 changes: 4 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

A description about what this pull request implements and its purpose. Try to be detailed and describe any technical details to simplify the job of the reviewer and the individual on production support.

#### Requirements

- [ ] CHANGELOG.md entry added (required for code changes only)

#### Tickets / Documentation

Add links to any relevant tickets and documentation.
Expand Down
19 changes: 2 additions & 17 deletions .github/workflows/pull_request_review.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# This workflow will do a clean install of your theme's dependencies and attempt to bundle the theme with Stencil CLI.
# This workflow will do a clean install of your theme's dependencies and attempt to bundle the theme with Stencil CLI.
# If the theme fails to bundle, you can review the error logs to find out why.
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions

Expand All @@ -23,20 +23,6 @@ jobs:
- name: Checkout code
uses: actions/checkout@v2

- name: Ruby Gem cache
uses: actions/cache@v2.1.3
with:
path: vendor/bundle
key: ${{ runner.os }}-gems-${{ hashFiles('**/Gemfile.lock') }}
restore-keys: |
${{ runner.os }}-gems-
- name: Setup Ruby 2.7
uses: ruby/setup-ruby@v1.51.1
with:
ruby-version: 2.7
- run: bundle install

- name: Use Node.js ${{ matrix.node }}
uses: actions/setup-node@v3
with:
Expand All @@ -56,7 +42,7 @@ jobs:
- name: Install Theme Dependencies
run: npm ci

- name: Grunt Check
- name: Grunt Check
run: npx grunt check

- name: Validate theme successfully bundles
Expand All @@ -67,7 +53,6 @@ jobs:
with:
name: Bundled Theme
path: bundle.zip

- name: Upload bundle analysis
uses: actions/upload-artifact@v2
with:
Expand Down
60 changes: 0 additions & 60 deletions .scss-lint.yml

This file was deleted.

23 changes: 23 additions & 0 deletions .stylelintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"extends": "stylelint-config-sass-guidelines",
"plugins": [
"stylelint-scss"
],
"rules": {
"color-named": null,
"indentation": 4,
"max-nesting-depth": null,
"property-no-vendor-prefix": null,
"selector-no-vendor-prefix": null,
"scss/at-mixin-pattern": null,
"scss/dollar-variable-colon-space-after": null,
"scss/dollar-variable-pattern": null,
"scss/percent-placeholder-pattern": null,
"selector-class-pattern": null,
"selector-max-compound-selectors": null,
"selector-max-id": null,
"selector-no-qualifying-type": null,
"string-quotes": "double",
"value-no-vendor-prefix": null
}
}
58 changes: 38 additions & 20 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,34 @@
# Changelog
All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Draft

## 5.7.1 (07-09-2021)
## 6.0.0 (08-06-2021)
- Translation mechanism for config.json has been updated. [#2089](https://github.com/bigcommerce/cornerstone/pull/2089)
- As a shopper I want to see gift wrapping price in product list the cart. [#2093](https://github.com/bigcommerce/cornerstone/pull/2093)
- Fixed wishlist dropdown shift on quick view modal. [#2102](https://github.com/bigcommerce/cornerstone/pull/2102)
- Empty email input in newsletter field should trigger an error. [#2101](https://github.com/bigcommerce/cornerstone/pull/2101)
- Make Hero Carousel both slide and button clickable when button enabled. [#2098](https://github.com/bigcommerce/cornerstone/pull/2098)
- "Manage Website Data Collection Preferences" phrase is not translatable. [#2090](https://github.com/bigcommerce/cornerstone/pull/2090)
- No navigation back to wishlist tab when you are in a wishlist. [#2096](https://github.com/bigcommerce/cornerstone/pull/2096)
- Reviews pagination navigation buttons reload page and does not open the Reviews tab. [#2048](https://github.com/bigcommerce/cornerstone/pull/2048)
- Fix social share links for product pages and blog posts [#2082](https://github.com/bigcommerce/cornerstone/pull/2082)
- 'undefined' is announced with screen reader while changing Product quantity on PDP. [#2094](https://github.com/bigcommerce/cornerstone/pull/2094)
- Counter on the Wish Lists tab on Account page has been removed. [#2087](https://github.com/bigcommerce/cornerstone/pull/2087)
- User Account, bug styles in section payment methods. [#2085](https://github.com/bigcommerce/cornerstone/pull/2085)
- Scss lint has been replaced with stylelint. [#2069](https://github.com/bigcommerce/cornerstone/pull/2069)

## 5.7.1 (2021-07-09)
- Update lang files for some locales. [#2086](https://github.com/bigcommerce/cornerstone/pull/2086)


## 5.7.0 (07-01-2021)
## 5.7.0 (2021-07-01)
- Implement CEV language files into Cornerstone. [#2084](https://github.com/bigcommerce/cornerstone/pull/2084)
- Added translations for Consent Manager. [#2083](https://github.com/bigcommerce/cornerstone/pull/2083)

## 5.6.0 (06-15-2021)
## 5.6.0 (2021-06-15)
- Translation mechanism for config.json values have been implemented. [#2076](https://github.com/bigcommerce/cornerstone/pull/2076)
- Enter press on Compare checkbox cause quick view opening. [#2074](https://github.com/bigcommerce/cornerstone/pull/2074)
- Product images in quick view can be squashed. [#2075](https://github.com/bigcommerce/cornerstone/pull/2075)
Expand All @@ -28,7 +46,7 @@
- Fixed NaN error on increase/decrease product quantity by adding field validation. [#2052](https://github.com/bigcommerce/cornerstone/pull/2052)
- Fixed social share links on blog post. [#2077](https://github.com/bigcommerce/cornerstone/pull/2077)

## 5.5.0 (05-20-2021)
## 5.5.0 (2021-05-20)
- Scale focus trap for all modals. [#2049](https://github.com/bigcommerce/cornerstone/pull/2049)
- Fixed displaying swatch name for multiple swatch options on page. [#2040](https://github.com/bigcommerce/cornerstone/pull/2040)
- Added settings for payment banners. [#2021](https://github.com/bigcommerce/cornerstone/pull/2021)
Expand All @@ -37,7 +55,7 @@
- Apple pay button displaying needs to be fixed. [#2043](https://github.com/bigcommerce/cornerstone/pull/2043)
- Fixed search result on search page not notified by screen reader. [#2024](https://github.com/bigcommerce/cornerstone/pull/2024)

## 5.4.0 (04-26-2021)
## 5.4.0 (2021-04-26)
- Incorrect focus order for product carousels. [#2034](https://github.com/bigcommerce/cornerstone/pull/2034)
- Removed duplicates of main tag.[#2032](https://github.com/bigcommerce/cornerstone/pull/2032)
- Hamburger Menu Icon missing on Google AMP Pages. [#2022](https://github.com/bigcommerce/cornerstone/pull/2022)
Expand All @@ -49,7 +67,7 @@
- Fixed unnecessary horizontal scroll on swatch options on PDP. [#2023](https://github.com/bigcommerce/cornerstone/pull/2023)
- Always showing product counts for Category facet in the faceted search results page. [#2035](https://github.com/bigcommerce/cornerstone/pull/2035)

## 5.3.0 (03-25-2021)
## 5.3.0 (2021-03-25)
- Remove AddThis for social sharing, replace with provider sharing links. [#1997](https://github.com/bigcommerce/cornerstone/pull/1997)
- IE11 - Clicking on Search Does Not Display Search Bar. [#2017](https://github.com/bigcommerce/cornerstone/pull/2017)
- Alt text should include product name for ratings. [#2015](https://github.com/bigcommerce/cornerstone/pull/2015)
Expand All @@ -67,7 +85,7 @@
- Added notifications on Carousel's content cahnge through 'Next/Prev' buttons. [#1986](https://github.com/bigcommerce/cornerstone/pull/1986)
- Add error message when faceted search fails on search, category, brand pages [#2005](https://github.com/bigcommerce/cornerstone/pull/2005)

## 5.2.0 (02-22-2021)
## 5.2.0 (2021-02-22)
- Fixed cut off on Cart button when Zooming up to 400%. [#1988](https://github.com/bigcommerce/cornerstone/pull/1988)
- Category pages are creating alt attribute within the span tag. [1987](https://github.com/bigcommerce/cornerstone/pull/1987)
- Add alt attribute for no image placeholders. [#1984](https://github.com/bigcommerce/cornerstone/pull/1984)
Expand All @@ -84,7 +102,7 @@
- Integrate accessibility scripts to product images slider on PDP. [#1965](https://github.com/bigcommerce/cornerstone/pull/1965)
- Move focus on filter items Modal after show more button was clicked and accessibility refactoring. [#1977](https://github.com/bigcommerce/cornerstone/pull/1977)

## 5.1.0 (01-26-2021)
## 5.1.0 (2021-01-26)
- Updated Cornerstone theme and respected variants to meet the verticals/industries documented in BCTHEME-387
- Fixed selecting certain option types which pushes window view to the bottom of the page. [#1959](https://github.com/bigcommerce/cornerstone/pull/1959)
- Fixed case when default option is out of stock add to cart button does not populate for in stock options. [#1955](https://github.com/bigcommerce/cornerstone/pull/1955)
Expand All @@ -111,7 +129,7 @@
- Bump stencil utils to 6.8.0. [#1945](https://github.com/bigcommerce/cornerstone/pull/1945)
- Bump stencil utils to 6.8.1. and removed changes from #1910 [#1945](https://github.com/bigcommerce/cornerstone/pull/1945)

## 5.0.0 (12-14-2020)
## 5.0.0 (2020-12-14)
- Parse HTML entities in jsContext. [#1917](https://github.com/bigcommerce/cornerstone/pull/1917)
- Product images squashed in Category view in AMP. [#1921](https://github.com/bigcommerce/cornerstone/pull/1921)
- Fixed misaligned tooltip for required product option. [#1915](https://github.com/bigcommerce/cornerstone/pull/1915)
Expand All @@ -138,12 +156,12 @@
- Added new region on the cart page [#1901](https://github.com/bigcommerce/cornerstone/pull/1901)
- Add pagination for Wishlists.[#1906](https://github.com/bigcommerce/cornerstone/pull/1906)

## 4.12.1 (11-10-2020)
## 4.12.1 (2020-11-10)
- Write a Review modal cause TypeError. [#1899](https://github.com/bigcommerce/cornerstone/pull/1899)
- Account >Payment Methods throws Server Error when using Cornerstone theme [#1898](https://github.com/bigcommerce/cornerstone/pull/1898)
- Price in the cart is not updated when changing currency on mobile. [#1893](https://github.com/bigcommerce/cornerstone/pull/1893)

## 4.12.0 (11-05-2020)
## 4.12.0 (2020-11-05)
- Reduce lodash usage in compare-products.js and image-gallery.js [#1827](https://github.com/bigcommerce/cornerstone/pull/1827)
- Fixed Product Image Carousel Becomes Responsiveness on Product Page. [#1879](https://github.com/bigcommerce/cornerstone/pull/1879)
- Move phrases and static strings to en.json for improving translation customizing. [#1850](https://github.com/bigcommerce/cornerstone/pull/1850)
Expand Down Expand Up @@ -178,7 +196,7 @@
- Unified browsers list that we support. [#1836](https://github.com/bigcommerce/cornerstone/pull/1836)
- Bump stencil utils and update hooks to account for refactor to drop Jquery in stencil utils [#1821](https://github.com/bigcommerce/cornerstone/pull/1821)

## 4.11.0 (10-07-2020)
## 4.11.0 (2020-10-07)
- Add Info and Add Coupon forms on Cart Page tabbable when hidden. [#1820](https://github.com/bigcommerce/cornerstone/pull/1820)
- Fixed outline styles for breadcrumbs on focus state. [#1824](https://github.com/bigcommerce/cornerstone/pull/1824)
- Fixed review rating icons focus border. [#1819](https://github.com/bigcommerce/cornerstone/pull/1819)
Expand All @@ -204,7 +222,7 @@
- Add global region to header. [#1859](https://github.com/bigcommerce/cornerstone/pull/1859)
- Add search message on storefront if search fails on backend. [#1885](https://github.com/bigcommerce/cornerstone/pull/1885)

## 4.10.0 (10-01-2020)
## 4.10.0 (2020-10-01)
- Return heading to product card. [#1848](https://github.com/bigcommerce/cornerstone/pull/1848)
- Quick search query param needs to be fixed while navigating to search page. [#1832](https://github.com/bigcommerce/cornerstone/pull/1832)
- Create unified focus styling in Cornerstone. [#1812](https://github.com/bigcommerce/cornerstone/pull/1812)
Expand Down Expand Up @@ -240,7 +258,7 @@
- Added tooltips for carousel Previous and Next buttons. [#1749](https://github.com/bigcommerce/cornerstone/pull/1749)
- Card content truncated on zooming browser to 400%. [#1803](https://github.com/bigcommerce/cornerstone/pull/1803)

## 4.9.0 (07-28-2020)
## 4.9.0 (2020-07-28)
- Added correct alt text on image change in product view. [#1747](https://github.com/bigcommerce/cornerstone/pull/1747)
- Description tab is hidden in case of empty product descrioption. [#1746](https://github.com/bigcommerce/cornerstone/pull/1746)
- Stencil cli updated to the latest version. [#1744](https://github.com/bigcommerce/cornerstone/pull/1744)
Expand All @@ -261,7 +279,7 @@
- Added 'none' options for non-required fields. [#1714](https://github.com/bigcommerce/cornerstone/pull/1714)
- Fixed thumbnail videos behaviour on click. [#1706](https://github.com/bigcommerce/cornerstone/pull/1706)

## 4.8.0 (07-20-2020)
## 4.8.0 (2020-07-20)
- Fixed Facebook button during modal scrolling behaviour. [#1724](https://github.com/bigcommerce/cornerstone/pull/1724)
- Fixed Product Image dimensions not constrained proportionally on Cart page which can lead to element overlapping. [#1722](https://github.com/bigcommerce/cornerstone/pull/1722)
- Added byte type on file upload options when max file size feature is enabled. [#1721](https://github.com/bigcommerce/cornerstone/pull/1721)
Expand All @@ -284,7 +302,7 @@
- Fixes the Sale badge so that it displays in list views. [#1694](https://github.com/bigcommerce/cornerstone/pull/1694)
- Added modal before switching currencies. [#1668](https://github.com/bigcommerce/cornerstone/pull/1668)

## 4.7.0 (06-26-2020)
## 4.7.0 (2020-06-26)
- Document polyfilling strategy in readme. [#1696](https://github.com/bigcommerce/cornerstone/pull/1696)
- Optimize polyfills to reduce download sizes on newer browsers as a way to improve performance. [#1669](https://github.com/bigcommerce/cornerstone/pull/1669)
- Fixed the expand/collapse behavior for Custom filters thad do not have an '&' in their name. [#1693](https://github.com/bigcommerce/cornerstone/pull/1693)
Expand All @@ -295,7 +313,7 @@
- Display wallet on drop-down section from cart [#1687](https://github.com/bigcommerce/cornerstone/pull/1687)


## 4.6.1 (05-28-2020)
## 4.6.1 (2020-05-28)
No actual PR updates. Fixes config values.

## 4.6.0 (2020-05-28)
Expand All @@ -306,11 +324,11 @@ No actual PR updates. Fixes config values.
-Add a better admin bar [#1664|https://github.com/bigcommerce/cornerstone/pull/1664]
-Update package-lock.json [#1676|https://github.com/bigcommerce/cornerstone/pull/1676]

## 4.5.4 (05-13-2020)
## 4.5.4 (2020-05-13)
-Bump jQuery version, expose jquery globally so it doesn't need to be loaded separately [#1671|https://github.com/bigcommerce/cornerstone/pull/1671]
-Revert Add handlebars class/style variables for account fields [#1674|https://github.com/bigcommerce/cornerstone/pull/1674]

## 4.5.3 (05-12-2020)
## 4.5.3 (2020-05-12)

## 4.5.2 (2020-05-12)

Expand Down
1 change: 1 addition & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ Unsure where to begin contributing to Stencil? Check our [forums](https://forum.
* Fill in [the required template](https://github.com/bigcommerce/cornerstone/pull/new/master)
* Include screenshots and animated GIFs in your pull request whenever possible.
* End files with a newline.
* Update CHANGELOG.md with a reference to your pull request if changing code

## Styleguides

Expand Down
3 changes: 0 additions & 3 deletions Gemfile

This file was deleted.

17 changes: 0 additions & 17 deletions Gemfile.lock

This file was deleted.

13 changes: 4 additions & 9 deletions Gruntfile.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,8 @@
module.exports = function(grunt) {
module.exports = function (grunt) {
require('time-grunt')(grunt);
require('load-grunt-config')(grunt, {
jitGrunt: {
staticMappings: {
scsslint: 'grunt-scss-lint'
}
}
});
require('load-grunt-config')(grunt);

grunt.loadNpmTasks('grunt-run');
grunt.registerTask('default', ['eslint', 'jest', 'scsslint', 'svgstore'])
grunt.loadNpmTasks('grunt-stylelint');
grunt.registerTask('default', ['eslint', 'svgstore']);
};
2 changes: 2 additions & 0 deletions assets/js/theme/common/carousel/utils/getActiveSlideInfo.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@ export default ({ $slider }, isAnalyzedDataAttr) => {

const $activeSlideImg = $activeSlide.find('.heroCarousel-image');
const activeSlideImgNode = $activeSlideImg[0];
const $activeSlideAndClones = $slider.find(`[data-hero-slide=${$activeSlide.data('hero-slide')}]`);

return {
$slider,
$activeSlide,
$activeSlideImg,
activeSlideImgNode,
$activeSlideAndClones,
};
};
Loading

0 comments on commit d7f51cb

Please sign in to comment.