-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add meson_python to PYTHON_TOOLCHAIN #36321
Conversation
No, that's not needed (and does not fix it). I've fixed it already in #36276. |
I don't get it it. It has nothing to do with spkg-configure stuff, and anyway I don't see how it's fixed. Are you saying |
There was a bug that caused meson_python to be recognized as a system-provided package. |
I'd even say that #36276 is already overfull with not directly related issues, so have this fixed there isn't very transparent, and has to be explicitly mentioned - if it's indeed the case. |
Read the PR description -- it's already there. |
I don't understand. |
Where? There is nothing on it in #36276 (comment) |
"Fixes https://groups.google.com/g/sage-release/c/1wOBmhvNJqc/m/Jk14VAbjBAAJ (hence marked critical)" |
Do you see it? |
Yes, it does not belong there because most Python packages don't need it. |
The bug was that it was marked as a package available from the system when it wasn't. |
Documentation preview for this PR (built with commit 6412e93; changes) is ready! 🎉 |
fix race condition for building scipy, possibly other meson_python deps
cf e.g. sage-dev report