Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add meson_python to PYTHON_TOOLCHAIN #36321

Closed
wants to merge 1 commit into from

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented Sep 24, 2023

fix race condition for building scipy, possibly other meson_python deps

cf e.g. sage-dev report

@mkoeppe
Copy link
Member

mkoeppe commented Sep 24, 2023

No, that's not needed (and does not fix it). I've fixed it already in #36276.

@dimpase
Copy link
Member Author

dimpase commented Sep 24, 2023

I don't get it it. It has nothing to do with spkg-configure stuff, and anyway I don't see how it's fixed. Are you saying meson_python does not belong to PYTHON_TOOLCHAIN? If not, one still needs it ready for e.g. scipy.

@dimpase dimpase reopened this Sep 24, 2023
@mkoeppe
Copy link
Member

mkoeppe commented Sep 24, 2023

It has nothing to do with spkg-configure stuff, and anyway I don't see how it's fixed.

There was a bug that caused meson_python to be recognized as a system-provided package.
For such packages, build/make/Makefile will have meson_python in DUMMY_PACKAGES, and thus the dependency on meson_python is rewritten as a dependency on the .dummy file.

@dimpase
Copy link
Member Author

dimpase commented Sep 24, 2023

I don't get it it. It has nothing to do with spkg-configure stuff, and anyway I don't see how it's fixed. Are you saying meson_python does not belong to PYTHON_TOOLCHAIN? If not, one still needs it ready for e.g. scipy.

I'd even say that #36276 is already overfull with not directly related issues, so have this fixed there isn't very transparent, and has to be explicitly mentioned - if it's indeed the case.

@mkoeppe
Copy link
Member

mkoeppe commented Sep 24, 2023

Read the PR description -- it's already there.

@mkoeppe mkoeppe closed this Sep 24, 2023
@dimpase
Copy link
Member Author

dimpase commented Sep 24, 2023

I don't understand. meson_python may or may not be a system package, How is it in this regard different to other packages in PYTHON_TOOLCHAIN ?

@dimpase
Copy link
Member Author

dimpase commented Sep 24, 2023

Read the PR description -- it's already there.

Where? There is nothing on it in #36276 (comment)

@dimpase dimpase reopened this Sep 24, 2023
@mkoeppe
Copy link
Member

mkoeppe commented Sep 24, 2023

"Fixes https://groups.google.com/g/sage-release/c/1wOBmhvNJqc/m/Jk14VAbjBAAJ (hence marked critical)"

@mkoeppe
Copy link
Member

mkoeppe commented Sep 24, 2023

Do you see it?

@mkoeppe
Copy link
Member

mkoeppe commented Sep 24, 2023

Are you saying meson_python does not belong to PYTHON_TOOLCHAIN?

Yes, it does not belong there because most Python packages don't need it.

@mkoeppe
Copy link
Member

mkoeppe commented Sep 24, 2023

I don't understand. meson_python may or may not be a system package

The bug was that it was marked as a package available from the system when it wasn't.

@github-actions
Copy link

Documentation preview for this PR (built with commit 6412e93; changes) is ready! 🎉

@dimpase dimpase closed this Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants