-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dft for symmetric group algebra when p|n! #37748
Closed
jacksonwalters
wants to merge
15
commits into
sagemath:develop
from
jacksonwalters:symmetric_group_dft_modular_case
Closed
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f13ce98
dft for symmetric group algebra when p|n
jacksonwalters 488b957
Update symmetric_group_algebra.py
jacksonwalters ac3a65b
remove trailing whitespace
jacksonwalters c52728e
finish adapting from Jupyter notebook
jacksonwalters e8dfbd0
put all code into single lines
jacksonwalters 6599439
Update symmetric_group_algebra.py
jacksonwalters 1be5ea9
Update symmetric_group_algebra.py
jacksonwalters ef83c0f
try formatting matrix
jacksonwalters 9272f20
example was wrong
jacksonwalters 132db04
matrix is misspelled
jacksonwalters 156e9aa
use transpose to get matrix of coordinate vectors
jacksonwalters 01793f2
Update src/sage/combinat/symmetric_group_algebra.py
jacksonwalters 327b3b4
Update src/sage/combinat/symmetric_group_algebra.py
jacksonwalters 2c83a02
Update symmetric_group_algebra.py
jacksonwalters 2fa1ab6
add commentary explaining the DFT in this case
jacksonwalters File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be a good idea to catch the error in the case$p \mid n$ here and raise an error with a clearer error message, or to remove the standard argument for $n$ (depending on whether
form
and choose it depending on whether the characteristic divides._dft_seminormal
always fails in the modular case)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, at the very least the failing cases p|n should at least be handled with a clear error message. I believe it only fails when p | n! (n was a type - it's the order of the symmetric group, so n!). I've chosen to just remove the standard argument for form and return the modular DFT in that case.