Addition of Chow ring ideal and Chow ring classes #38281
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 980c63f; changes) is ready! 🎉 |
tscrim
added
c: combinatorics
c: algebra
c: matroid theory
gsoc: 2024
tscrim
requested changes
Sep 23, 2024
src/sage/matroids/chow_ring.py
Outdated
|
|
||
| ..MATH:: | ||
|
|
||
| A(M)_R := R[y_{e_1}, \ldots, y_{e_n}, x_{F_1}, \ldots, x_{F_k}] / (I_M + J_M) |
There was a problem hiding this comment.
Suggested change
| A(M)_R := R[y_{e_1}, \ldots, y_{e_n}, x_{F_1}, \ldots, x_{F_k}] / (I_M + J_M) | |
| A(M)_R := R[y_{e_1}, \ldots, y_{e_n}, x_{F_1}, \ldots, x_{F_k}] / (I_M + J_M), |
src/sage/matroids/chow_ring.py
Outdated
Comment on lines
42
to
44
| A(M)_R := R[x_{F_1}, \ldots, x_{F_k}] / I_{af}M | ||
|
|
||
| where `I_{af}M` is the augmented Chow ring ideal of matroid `M` of atom-free presentation. |
There was a problem hiding this comment.
Suggested change
| A(M)_R := R[x_{F_1}, \ldots, x_{F_k}] / I_{af}M | |
| where `I_{af}M` is the augmented Chow ring ideal of matroid `M` of atom-free presentation. | |
| A(M)_R := R[x_{F_1}, \ldots, x_{F_k}] / I_M^{af}, | |
| where `I_M^{af}` is the augmented Chow ring ideal of matroid `M` in the atom-free presentation. |
src/sage/matroids/chow_ring.py
Outdated
| else: | ||
| self._ideal = ChowRingIdeal_nonaug(M, R) | ||
| C = CommutativeRings().Quotients() & GradedAlgebrasWithBasis(R).FiniteDimensional() | ||
| QuotientRing_generic.__init__(self, R=self._ideal.ring(), I=self._ideal, names=self._ideal.ring().variable_names(), category=C) |
There was a problem hiding this comment.
Suggested change
| QuotientRing_generic.__init__(self, R=self._ideal.ring(), I=self._ideal, names=self._ideal.ring().variable_names(), category=C) | |
| QuotientRing_generic.__init__(self, R=self._ideal.ring(), | |
| I=self._ideal, | |
| names=self._ideal.ring().variable_names(), | |
| category=C) |
So it is closer to 80 char/ line.
src/sage/matroids/chow_ring.py
Outdated
Comment on lines
130
to
131
| import sage.misc.latex as latex | ||
| return "%s/%s" % (latex.latex(self._ideal.ring()), latex.latex(self._ideal)) |
There was a problem hiding this comment.
Suggested change
| import sage.misc.latex as latex | |
| return "%s/%s" % (latex.latex(self._ideal.ring()), latex.latex(self._ideal)) | |
| From sage.misc.latex import latex | |
| return "{} / {}".format(latex(self._ideal.ring()), latex(self._ideal)) |
src/sage/matroids/chow_ring.py
Outdated
Comment on lines
137
to
139
| TESTS:: | ||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| TESTS:: | |
| TESTS:: | |
src/sage/matroids/chow_ring_ideal.py
Outdated
| sage: ch | ||
| Chow ring ideal of Fano: Binary matroid of rank 3 on 7 elements, type (3, 0) | ||
| """ | ||
| return "Chow ring ideal of {}".format(self._matroid) |
There was a problem hiding this comment.
Shouldn’t this be more specific? Also, please add a _latex_() method.
src/sage/matroids/chow_ring_ideal.py
Outdated
Comment on lines
194
to
199
| Returns the Groebner basis of the Chow ring ideal. | ||
|
|
||
| EXAMPLES:: | ||
|
|
||
| sage: from sage.matroids.basis_matroid import BasisMatroid | ||
|
|
There was a problem hiding this comment.
Suggested change
| Returns the Groebner basis of the Chow ring ideal. | |
| EXAMPLES:: | |
| sage: from sage.matroids.basis_matroid import BasisMatroid | |
| Return the Groebner basis of `self`. | |
| EXAMPLES:: | |
| sage: from sage.matroids.basis_matroid import BasisMatroid |
It would be better to use the standard Sage global namespace way to build the matroid rather than via an import.
|
|
||
| A(M)_R := R[y_{e_1}, \ldots, y_{e_n}, x_{F_1}, \ldots, x_{F_k}] / (I_M + J_M) | ||
|
|
||
| where `(I_M + J_M)` is the augmented Chow ring ideal of matroid `M` |
There was a problem hiding this comment.
Suggested change
| where `(I_M + J_M)` is the augmented Chow ring ideal of matroid `M` | |
| where `(I_M + J_M)` is the :class:`augmented Chow ring ideal | |
| <sage.matroids.chow_ring_ideal.ChowRingIdeal_fy>` | |
| of the matroid `M` in the |
Comment on lines
+59
to
+61
| * ``"atom-free" - Atom-free presentation* | ||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| * ``"atom-free" - Atom-free presentation* | |
| * ``"atom-free" - Atom-free presentation* | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is focused on addition of classes for Chow ring ideal and Chow ring of matroids.
Check relevant issue.
The ideals classes consist of the Chow ring ideal and Augmented Chow ring ideal, with Gröbner basis for each of them.
The Chow ring class is an initial version.
@tscrim
📝 Checklist
⌛ Dependencies