Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure.ac: disable more packages with --disable-notebook #38662

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

orlitzky
Copy link
Contributor

The h11 package is used only by httpcore, and httpcore is used only by httpx, and httpx is used only by jupyterlab. Since jupyterlab is already disabled by --disable-notebook, the others can be too.

Copy link

github-actions bot commented Sep 15, 2024

Documentation preview for this PR (built with commit 5fbd4b4; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@dimpase
Copy link
Member

dimpase commented Sep 23, 2024

please rebase

The h11 package is used only by httpcore, and httpcore is used only by
httpx, and httpx is used only by jupyterlab. Since jupyterlab is
already disabled by --disable-notebook, the others can be too.
@orlitzky
Copy link
Contributor Author

sure thing, done

Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

(The error message one gets while trying to start a notebook in such a config via ./sage -n is rather ugly, but that's another story)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants