Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set partition to disjoint set #38693

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

thecaligarmo
Copy link
Contributor

@thecaligarmo thecaligarmo commented Sep 22, 2024

This issue fixes the bug in #38415 . It uses the base of SetPartition to allow a DisjointSet to be created in a nice way. This also solves issue #38416

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

#38415 , #38416

Copy link

github-actions bot commented Sep 22, 2024

Documentation preview for this PR (built with commit 0761846; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM.

{{0}, {1}, {2}, {3}, {4}}
sage: DisjointSet(SP) == DisjointSet(5)
True

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 empty line is enough

@@ -103,6 +104,15 @@ cpdef DisjointSet(arg):
sage: DisjointSet(['yi', 45, 'cheval'])
{{'cheval'}, {'yi'}, {45}}

From a set partition::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could add a reference to the issue or the PR using (see :issue:`12345`)

@thecaligarmo
Copy link
Contributor Author

Fixed. I also forgot that this issue handles #38416 by providing the alternative solution.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go back to positive review after rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants