-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some pep8 fixes in sage/all.py #38696
base: develop
Are you sure you want to change the base?
Conversation
Documentation preview for this PR (built with commit cbd9c2d; changes) is ready! 🎉 |
register_unpickle_override('sage.libs.pari.gen_py', 'pari', pari) | ||
|
||
# Cache the contents of star imports. | ||
sage.misc.lazy_import.save_cache_file() | ||
|
||
|
||
### Debugging for Singular, see trac #10903 | ||
# Debugging for Singular, see trac #10903 | ||
# from sage.libs.singular.ring import poison_currRing | ||
# sys.settrace(poison_currRing) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first line is a comment to the following commented code lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# # Debugging for Singular, see Issue #10903
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is capitalized "Issue"... How about "##" instead of "####"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
come on, please spare my time and yours.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Not a big issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (except the issue :-)
This is fixing
E272 multiple spaces before keyword
in all.py
📝 Checklist