Workaround Parametrized Host

[joheredi]

The changes in swagger to work around the parametrized host issue has a negative impact in TS Rest Client as the ApiVersion will now have to be passed on every operation.

Tim was kind enough to put out a fix in M4 Azure/autorest#4657 which I'm using in this change. There is still a gap in the @azure/autorest.typescript plugin to correctly handle it, in the meantime, I have addressed the gap manually.

To make this work I added a few Swagger transforms discussed offline with Laurent

Additionally I'm adding a workaround fix for isUnexpected to work correctly with parametrized host.

[joheredi]

This is the manual change I had to do:

1. Add apiVersion to clientOptions
2. create the apiVersion variable, if options.apiVersion is not provided then, use the default from swagger.

[joheredi]

@MaryGao, @qiaozha do you think we can integrate this to the codegen? This is dependent on Azure/autorest#4657

[MaryGao]

I created an issue to track this Azure/autorest.typescript#1635.

I am okay with the temp workaround but regarding the long-term support we need to define below details:

• Is this logic stick to apiVersion only or general optional host parameter?
• This param would be required or optional, how to define different behavior in codegen?
• Do we need to put parameter into AnomalyDetectorClientOption?

export interface AnomalyDetectorClientOption extends ClientOptions {
  apiVersion?: string;
}

Let's talk about them in our issue.

[joheredi]

This is the fix I have for parametrized hosts. Instead of checking from the front. Start at the end and walk our way back, if no mismatch at the end we assume it is the same path.

@MaryGao - What do you think? If this works correctly I think we should be able to easily port it to codegen.

@saintzou66 - would you mind verifying if this fix works?

[MaryGao]

One concern for this - if we have similar suffix of two urls we may miss to match the correct one:

url1: http://localhost:80/service/v1.1/a/b/c      ==> swagger path section: a/b/c
url2: http://localhost:80/service/v1.1/a/b/a/b/c  ==> swagger path section: a/b/a/b/c

Then the a/b/c segment could match both of them. Actually the shorter one would be more accurate.

Do you think we need to add more logic to check if this is the shorter one?

[joheredi]

Yeah, maybe we need a way to include the whole parametrized host to be sure the match is accurate

[joheredi]

Do we have such a scenario in this library? If not, we can go with this workaround while we do the long term fix in the codegen

[MaryGao]

There is no this case in this library

[joheredi]

Updated isUnexpected, @saintzou66 can you please verify if this is now working?

[saintzou66]

It seems isUnexpected is still not working.
Here is the logging:
pathParts:
[ '', 'anomalydetector', 'v1.1', 'multivariate', 'models' ]
candidateParts:
[ '', 'timeseries', 'entire', 'detect' ]
[ '', 'timeseries', 'last', 'detect' ]
[ '', 'timeseries', 'changepoint', 'detect' ]
[ '', 'multivariate', 'models' ]
[ '', 'multivariate', 'models', '{modelId}:detect-batch' ]
[ '', 'multivariate', 'models', '{modelId}:detect-last' ]

As they have different parts of the whole url, the getParametrizedPathSuccess function will always return am empty array.

@joheredi

[MaryGao]

There is a bug when do comparation. We should ignore the first empty string.

[MaryGao]

Suggested change

	for (let i = candidateParts.length - 1; i >= 0; i--) {
	for (let i = candidateParts.length - 1; i >= 1; i--) {

The first part would always be empty space and will not use to do comparation

[saintzou66]

pathParts.length not always equal with candidateParts.length.

pathParts= [ '', 'anomalydetector', 'v1.1', 'multivariate', 'models' ]
candidateParts = [ '', 'multivariate', 'models' ]

[saintzou66]

There will be a pattern like this: /multivariate/models/{modelId}:detect-batch,
It includes {modelId}, but not end with '}'

[MaryGao]

Suggested change

	for (let i = candidateParts.length - 1; i >= 0; i--) {
	for (
	let i = candidateParts.length - 1, j = pathParts.length - 1;
	i >= 1 && j >= 1;
	i--, j--
	) {

[MaryGao]

Suggested change

	if (candidateParts[i] !== pathParts[i]) {
	if (candidateParts[i] !== pathParts[j]) {