Add redshift data endpoints #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the documentation, sending SQL statements to redshift is handled with different API: https://docs.aws.amazon.com/redshift-data/latest/APIReference/Welcome.html instead of https://docs.aws.amazon.com/redshift/latest/APIReference/Welcome.html so new service must be defined in the fork.
alcidesteixeira
approved these changes
May 22, 2024
|
I would assume that both redshift and redshift-data would be part of the elixir aws library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation, sending SQL statements to Redshift is handled with a different API:
https://docs.aws.amazon.com/redshift-data/latest/APIReference/Welcome.html instead of
https://docs.aws.amazon.com/redshift/latest/APIReference/Welcome.html so a new service must be defined in the fork.
Before opening a PR, please make sure you have:
mix formatusing a recent version of Elixirmix dialyzerto make sure the typing is correctmix testto ensure no tests have broken (also please make sure you've added tests for your particular change, where appropriate).