Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(builds): Merge upstream and add heroku-22 build #2

Merged
merged 20 commits into from
Mar 15, 2023

Conversation

Dottenpixel
Copy link
Contributor

@Dottenpixel Dottenpixel commented Mar 14, 2023

This work:

  • Merges in the latest from heroku/heroku-buildpack-nginx, which deprecates cedar-14 and heroku-16, and adds heroku-22
  • bumps zlib to 1.2.13 because attempts to build using 1.2.12 didn't make viable builds

beanieboi and others added 13 commits January 12, 2021 14:44
* remove references to cedar-14

* update changelog

Co-authored-by: Ben Fritsch <bfritsch@bfritsch-ltm2.internal.salesforce.com>
* rename master -> main

* changelog
* update to nginx 1.20

* avoid rebuilding for heroku-16
* removing heroku-16. closes heroku/heroku-buildpack-nginx#78

* update changelog
* nginx 1.20.1 addressing CVE-2021-23017 #82

* changelog
* Update nginx.conf.erb

* Update nginx-solo-sample.conf.erb

* Update nginx-nextjs-with-forcessl.conf.erb
* updates

* add binaries

* changelog

* bump zlib

* update changelog

* add new archives
Binary generated using `make build-heroku-22`.

GUS-W-10346716.
To pick up #96.

GUS-W-10346716.
The ERB templating feature of this buildpack requires that the
`erb` command (part of Ruby) be available at runtime, in order
that the nginx config templates can be rendered into a valid nginx
config.

On Heroku-22 the stack image no longer includes a system Ruby
installation, so in order for this buildpack to continue to work, a
Ruby install must be vendored by this buildpack.

If an app already uses the Ruby buildpack, and that buildpack is
ordered prior to the nginx buildpack, then this buildpack will skip
the Ruby vendoring step to save installing a redundant copy of Ruby.

Fixes #101.
GUS-W-11321729.
Copy link

@sumugapadman sumugapadman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Dottenpixel Dottenpixel merged commit db91108 into dse Mar 15, 2023
@Dottenpixel Dottenpixel deleted the chore/upstream-merge branch March 15, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants