-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match feature type map hierarchy with regular feature types #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tovbinm
changed the title
Update map feature type hierarchy
Match feature type map hierarchy with regular feature types
Aug 11, 2018
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
- Coverage 85.74% 84.84% -0.91%
==========================================
Files 298 298
Lines 9753 9760 +7
Branches 329 328 -1
==========================================
- Hits 8363 8281 -82
- Misses 1390 1479 +89
Continue to review full report at Codecov.
|
leahmcguire
approved these changes
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Currently it's not possible to restrict stage types by only numeric maps or only by real maps.
Describe the proposed solution
Update feature type map hierarchy to match the regular feature types hierarchy.
This change allows us restrict stage types by only numeric maps for instance:
Additional changes:
MultiPickListMap
now extendsMultiResponse
BinaryMap
andPickListMap
now extendSingleResponse
NumericMap
trait withtoDoubleMap: Map[String, Double]
(to match theOPNumeric
withtoDouble: Option[Double]
)Describe alternatives you've considered
None.
Additional context
We should have done it from day one.