Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS-neutral filesystem path creation #51

Merged
merged 2 commits into from
Aug 14, 2018
Merged

OS-neutral filesystem path creation #51

merged 2 commits into from
Aug 14, 2018

Conversation

gerashegalov
Copy link
Contributor

Related issues
N/A

Describe the proposed solution
Avoid using explicit path separators

Describe alternatives you've considered
N/A

Additional context
N/A

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @gerashegalov to sign the Salesforce.com Contributor License Agreement.

@tovbinm
Copy link
Collaborator

tovbinm commented Aug 13, 2018

@gerashegalov please make sure you replaced it everywhere in the code.

@gerashegalov gerashegalov force-pushed the gera/path-creation branch 2 times, most recently from fbb19d7 to 8dc1ec5 Compare August 13, 2018 22:27
@codecov
Copy link

codecov bot commented Aug 13, 2018

Codecov Report

Merging #51 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   84.77%   84.77%   +<.01%     
==========================================
  Files         298      298              
  Lines        9751     9753       +2     
  Branches      340      329      -11     
==========================================
+ Hits         8266     8268       +2     
  Misses       1485     1485
Impacted Files Coverage Δ
...ain/scala/com/salesforce/op/cli/SchemaSource.scala 87.93% <100%> (ø) ⬆️
...main/scala/com/salesforce/op/test/TestCommon.scala 50% <100%> (+6.25%) ⬆️
...ain/scala/com/salesforce/op/OpWorkflowRunner.scala 86.95% <100%> (ø) ⬆️
...alesforce/op/cli/gen/templates/SimpleProject.scala 100% <100%> (ø) ⬆️
...salesforce/op/test/PassengerSparkFixtureTest.scala 79.16% <100%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5805c97...f1cfc60. Read the comment docs.

@gerashegalov
Copy link
Contributor Author

gerashegalov commented Aug 14, 2018

@tovbinm It was my intent to replace all occurrences. lmk if I missed some. Classpath resources are fine to leave as is.

Copy link
Collaborator

@tovbinm tovbinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! We can run it on Windows :)

@tovbinm tovbinm merged commit 4a60c3b into master Aug 14, 2018
@tovbinm tovbinm deleted the gera/path-creation branch August 14, 2018 13:35
@gerashegalov
Copy link
Contributor Author

Better be friends with github owners 😃

ericwayman pushed a commit that referenced this pull request Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants