Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow numbers and underscores in names #92

Merged
merged 1 commit into from
Aug 25, 2018
Merged

Conversation

leahmcguire
Copy link
Collaborator

Related issues
requirement was only so updating names on old model selector would work

Describe the proposed solution
allow numbers and underscores. removed unused method for name update

Copy link
Collaborator

@tovbinm tovbinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! lgtm.

@codecov
Copy link

codecov bot commented Aug 25, 2018

Codecov Report

Merging #92 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
+ Coverage   86.06%   86.13%   +0.06%     
==========================================
  Files         292      292              
  Lines        9521     9517       -4     
  Branches      336      335       -1     
==========================================
+ Hits         8194     8197       +3     
+ Misses       1327     1320       -7
Impacted Files Coverage Δ
.../main/scala/com/salesforce/op/stages/package.scala 60% <100%> (+26.66%) ⬆️
...om/salesforce/op/utils/spark/OpSparkListener.scala 98.7% <0%> (+1.29%) ⬆️
...es/src/main/scala/com/salesforce/op/OpParams.scala 89.58% <0%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6a5821...e8a464a. Read the comment docs.

@tovbinm tovbinm merged commit d749323 into master Aug 25, 2018
@tovbinm tovbinm deleted the lm/numbersInNames branch August 25, 2018 20:44
ericwayman pushed a commit that referenced this pull request Feb 8, 2019
@salesforce-cla
Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): leahmcguire <l***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants