perf(template-compiler): revert logical or assignment back to short-c…

…ircuit
salesforce · Aug 20, 2024 · c11f811 · c11f811
1 parent db92d72
commit c11f811
Show file tree

Hide file tree

Showing 18 changed files with 143 additions and 85 deletions.
diff --git a/.../template-compiler/src/__tests__/fixtures/dynamic-components/valid/attributes/expected.js b/.../template-compiler/src/__tests__/fixtures/dynamic-components/valid/attributes/expected.js
@@ -12,9 +12,11 @@ function tmpl($api, $cmp, $slotset, $ctx) {
       classMap: stc0,
       slotAssignment: "slotName",
       key: 0,
-      on: ($ctx._m0 ||= {
-        click: api_bind($cmp.handleClick),
-      }),
+      on:
+        _m0 ||
+        ($ctx._m0 = {
+          click: api_bind($cmp.handleClick),
+        }),
     }),
   ];
   /*LWC compiler vX.X.X*/

diff --git a/...@lwc/template-compiler/src/__tests__/fixtures/dynamic-components/valid/nested/expected.js b/...@lwc/template-compiler/src/__tests__/fixtures/dynamic-components/valid/nested/expected.js
@@ -23,9 +23,11 @@ function tmpl($api, $cmp, $slotset, $ctx) {
         classMap: stc0,
         props: stc1,
         key: 0,
-        on: ($ctx._m0 ||= {
-          click: api_bind($cmp.handleOuterClick),
-        }),
+        on:
+          _m0 ||
+          ($ctx._m0 = {
+            click: api_bind($cmp.handleOuterClick),
+          }),
       },
       [
         api_static_fragment($fragment1, 2),
@@ -35,9 +37,11 @@ function tmpl($api, $cmp, $slotset, $ctx) {
             classMap: stc0,
             props: stc1,
             key: 3,
-            on: ($ctx._m1 ||= {
-              click: api_bind($cmp.handleOuterClick),
-            }),
+            on:
+              _m1 ||
+              ($ctx._m1 = {
+                click: api_bind($cmp.handleOuterClick),
+              }),
           },
           [api_static_fragment($fragment2, 5)]
         ),

diff --git a/packages/@lwc/template-compiler/src/__tests__/fixtures/events/component/expected.js b/packages/@lwc/template-compiler/src/__tests__/fixtures/events/component/expected.js
@@ -12,9 +12,11 @@ function tmpl($api, $cmp, $slotset, $ctx) {
     api_element("section", stc0, [
       api_custom_element("ns-foo", _nsFoo, {
         key: 1,
-        on: ($ctx._m0 ||= {
-          foo: api_bind($cmp.handleFoo),
-        }),
+        on:
+          _m0 ||
+          ($ctx._m0 = {
+            foo: api_bind($cmp.handleFoo),
+          }),
       }),
     ]),
   ];

diff --git a/packages/@lwc/template-compiler/src/__tests__/fixtures/events/non-static/expected.js b/packages/@lwc/template-compiler/src/__tests__/fixtures/events/non-static/expected.js
@@ -11,9 +11,11 @@ function tmpl($api, $cmp, $slotset, $ctx) {
     api_element("div", stc0, [
       api_element("button", {
         key: 1,
-        on: ($ctx._m0 ||= {
-          click: api_bind($cmp.handleClick),
-        }),
+        on:
+          _m0 ||
+          ($ctx._m0 = {
+            click: api_bind($cmp.handleClick),
+          }),
       }),
     ]),
   ];

diff --git a/packages/@lwc/template-compiler/src/__tests__/fixtures/events/static/expected.js b/packages/@lwc/template-compiler/src/__tests__/fixtures/events/static/expected.js
@@ -10,9 +10,11 @@ function tmpl($api, $cmp, $slotset, $ctx) {
       api_static_part(
         1,
         {
-          on: ($ctx._m0 ||= {
-            click: api_bind($cmp.handleClick),
-          }),
+          on:
+            _m0 ||
+            ($ctx._m0 = {
+              click: api_bind($cmp.handleClick),
+            }),
         },
         null
       ),

diff --git a/packages/@lwc/template-compiler/src/__tests__/fixtures/events/tag/expected.js b/packages/@lwc/template-compiler/src/__tests__/fixtures/events/tag/expected.js
@@ -10,18 +10,22 @@ function tmpl($api, $cmp, $slotset, $ctx) {
       api_static_part(
         1,
         {
-          on: ($ctx._m0 ||= {
-            click: api_bind($cmp.handleClick),
-          }),
+          on:
+            _m0 ||
+            ($ctx._m0 = {
+              click: api_bind($cmp.handleClick),
+            }),
         },
         null
       ),
       api_static_part(
         3,
         {
-          on: ($ctx._m1 ||= {
-            press: api_bind($cmp.handlePress),
-          }),
+          on:
+            _m1 ||
+            ($ctx._m1 = {
+              press: api_bind($cmp.handlePress),
+            }),
         },
         null
       ),

diff --git a/packages/@lwc/template-compiler/src/__tests__/fixtures/events/type-valid/expected.js b/packages/@lwc/template-compiler/src/__tests__/fixtures/events/type-valid/expected.js
@@ -13,9 +13,11 @@ function tmpl($api, $cmp, $slotset, $ctx) {
       api_static_part(
         0,
         {
-          on: ($ctx._m1 ||= {
-            a123: api_bind($cmp.handleClick),
-          }),
+          on:
+            _m1 ||
+            ($ctx._m1 = {
+              a123: api_bind($cmp.handleClick),
+            }),
         },
         null
       ),
@@ -24,9 +26,11 @@ function tmpl($api, $cmp, $slotset, $ctx) {
       api_static_part(
         0,
         {
-          on: ($ctx._m3 ||= {
-            foo_bar: api_bind($cmp.handleClick),
-          }),
+          on:
+            _m3 ||
+            ($ctx._m3 = {
+              foo_bar: api_bind($cmp.handleClick),
+            }),
         },
         null
       ),
@@ -35,9 +39,11 @@ function tmpl($api, $cmp, $slotset, $ctx) {
       api_static_part(
         0,
         {
-          on: ($ctx._m5 ||= {
-            foo_: api_bind($cmp.handleClick),
-          }),
+          on:
+            _m5 ||
+            ($ctx._m5 = {
+              foo_: api_bind($cmp.handleClick),
+            }),
         },
         null
       ),
@@ -46,9 +52,11 @@ function tmpl($api, $cmp, $slotset, $ctx) {
       api_static_part(
         0,
         {
-          on: ($ctx._m7 ||= {
-            a123: api_bind($cmp.handleClick),
-          }),
+          on:
+            _m7 ||
+            ($ctx._m7 = {
+              a123: api_bind($cmp.handleClick),
+            }),
         },
         null
       ),

diff --git a/...piler/src/__tests__/fixtures/expression-complex/valid/assignment-inside-arrow/expected.js b/...piler/src/__tests__/fixtures/expression-complex/valid/assignment-inside-arrow/expected.js
@@ -10,9 +10,11 @@ function tmpl($api, $cmp, $slotset, $ctx) {
       api_static_part(
         1,
         {
-          on: ($ctx._m0 ||= {
-            click: api_bind(() => ($cmp.myField = "foo")),
-          }),
+          on:
+            _m0 ||
+            ($ctx._m0 = {
+              click: api_bind(() => ($cmp.myField = "foo")),
+            }),
         },
         null
       ),

diff --git a/...te-compiler/src/__tests__/fixtures/expression-complex/valid/computed-property/expected.js b/...te-compiler/src/__tests__/fixtures/expression-complex/valid/computed-property/expected.js
@@ -15,9 +15,11 @@ function tmpl($api, $cmp, $slotset, $ctx) {
       api_static_part(
         0,
         {
-          on: ($ctx._m1 ||= {
-            click: api_bind($cmp.bar.arr[$cmp.baz]),
-          }),
+          on:
+            _m1 ||
+            ($ctx._m1 = {
+              click: api_bind($cmp.bar.arr[$cmp.baz]),
+            }),
         },
         null
       ),

diff --git a/...wc/template-compiler/src/__tests__/fixtures/expression-complex/valid/iterator/expected.js b/...wc/template-compiler/src/__tests__/fixtures/expression-complex/valid/iterator/expected.js
@@ -16,9 +16,11 @@ function tmpl($api, $cmp, $slotset, $ctx) {
       api_static_part(
         1,
         {
-          on: ($ctx._m0 ||= {
-            click: api_bind(() => $cmp.taberu(okazu)),
-          }),
+          on:
+            _m0 ||
+            ($ctx._m0 = {
+              click: api_bind(() => $cmp.taberu(okazu)),
+            }),
         },
         null
       ),

diff --git a/...-compiler/src/__tests__/fixtures/expression-complex/valid/update-inside-arrow/expected.js b/...-compiler/src/__tests__/fixtures/expression-complex/valid/update-inside-arrow/expected.js
@@ -10,9 +10,11 @@ function tmpl($api, $cmp, $slotset, $ctx) {
       api_static_part(
         1,
         {
-          on: ($ctx._m0 ||= {
-            click: api_bind(() => $cmp.foo++),
-          }),
+          on:
+            _m0 ||
+            ($ctx._m0 = {
+              click: api_bind(() => $cmp.foo++),
+            }),
         },
         null
       ),

diff --git a/.../@lwc/template-compiler/src/__tests__/fixtures/regression/handler-memoization/expected.js b/.../@lwc/template-compiler/src/__tests__/fixtures/regression/handler-memoization/expected.js
@@ -22,9 +22,11 @@ function tmpl($api, $cmp, $slotset, $ctx) {
       api_static_part(
         0,
         {
-          on: ($ctx._m1 ||= {
-            click: api_bind($cmp.create),
-          }),
+          on:
+            _m1 ||
+            ($ctx._m1 = {
+              click: api_bind($cmp.create),
+            }),
         },
         null
       ),
@@ -38,9 +40,11 @@ function tmpl($api, $cmp, $slotset, $ctx) {
           api_static_part(
             2,
             {
-              on: ($ctx._m2 ||= {
-                click: api_bind(task.delete),
-              }),
+              on:
+                _m2 ||
+                ($ctx._m2 = {
+                  click: api_bind(task.delete),
+                }),
             },
             null
           ),

diff --git a/...wc/template-compiler/src/__tests__/fixtures/static-content/deep-data-combined/expected.js b/...wc/template-compiler/src/__tests__/fixtures/static-content/deep-data-combined/expected.js
@@ -15,9 +15,11 @@ function tmpl($api, $cmp, $slotset, $ctx) {
       api_static_part(
         4,
         {
-          on: ($ctx._m0 ||= {
-            click: api_bind($cmp.onClickBaz),
-          }),
+          on:
+            _m0 ||
+            ($ctx._m0 = {
+              click: api_bind($cmp.onClickBaz),
+            }),
           ref: "foo",
           style: $cmp.fooStyle,
           attrs: {
@@ -30,9 +32,11 @@ function tmpl($api, $cmp, $slotset, $ctx) {
       api_static_part(
         6,
         {
-          on: ($ctx._m1 ||= {
-            click: api_bind($cmp.onClickQuux),
-          }),
+          on:
+            _m1 ||
+            ($ctx._m1 = {
+              click: api_bind($cmp.onClickQuux),
+            }),
           ref: "bar",
           style: $cmp.barStyle,
           attrs: {

diff --git a/packages/@lwc/template-compiler/src/__tests__/fixtures/static-content/deep-data/expected.js b/packages/@lwc/template-compiler/src/__tests__/fixtures/static-content/deep-data/expected.js
@@ -22,9 +22,11 @@ function tmpl($api, $cmp, $slotset, $ctx) {
       api_static_part(
         5,
         {
-          on: ($ctx._m0 ||= {
-            click: api_bind($cmp.onClickBaz),
-          }),
+          on:
+            _m0 ||
+            ($ctx._m0 = {
+              click: api_bind($cmp.onClickBaz),
+            }),
         },
         null
       ),
@@ -55,9 +57,11 @@ function tmpl($api, $cmp, $slotset, $ctx) {
       api_static_part(
         10,
         {
-          on: ($ctx._m1 ||= {
-            click: api_bind($cmp.onClickQuux),
-          }),
+          on:
+            _m1 ||
+            ($ctx._m1 = {
+              click: api_bind($cmp.onClickQuux),
+            }),
         },
         null
       ),

diff --git a/...mpiler/src/__tests__/fixtures/static-content/preserve-comments-off-with-parts/expected.js b/...mpiler/src/__tests__/fixtures/static-content/preserve-comments-off-with-parts/expected.js
@@ -15,9 +15,11 @@ function tmpl($api, $cmp, $slotset, $ctx) {
       api_static_part(
         1,
         {
-          on: ($ctx._m0 ||= {
-            click: api_bind($cmp.onClickFoo),
-          }),
+          on:
+            _m0 ||
+            ($ctx._m0 = {
+              click: api_bind($cmp.onClickFoo),
+            }),
           ref: "foo",
           style: $cmp.fooStyle,
           className: api_normalize_class_name($cmp.fooClass),
@@ -30,9 +32,11 @@ function tmpl($api, $cmp, $slotset, $ctx) {
       api_static_part(
         3,
         {
-          on: ($ctx._m1 ||= {
-            click: api_bind($cmp.onClickBar),
-          }),
+          on:
+            _m1 ||
+            ($ctx._m1 = {
+              click: api_bind($cmp.onClickBar),
+            }),
           ref: "bar",
           style: $cmp.barStyle,
           className: api_normalize_class_name($cmp.barClass),

diff --git a/...ompiler/src/__tests__/fixtures/static-content/preserve-comments-on-with-parts/expected.js b/...ompiler/src/__tests__/fixtures/static-content/preserve-comments-on-with-parts/expected.js
@@ -10,9 +10,11 @@ function tmpl($api, $cmp, $slotset, $ctx) {
       api_static_part(
         2,
         {
-          on: ($ctx._m0 ||= {
-            click: api_bind($cmp.onClickFoo),
-          }),
+          on:
+            _m0 ||
+            ($ctx._m0 = {
+              click: api_bind($cmp.onClickFoo),
+            }),
           ref: "foo",
           style: $cmp.fooStyle,
           attrs: {
@@ -24,9 +26,11 @@ function tmpl($api, $cmp, $slotset, $ctx) {
       api_static_part(
         5,
         {
-          on: ($ctx._m1 ||= {
-            click: api_bind($cmp.onClickBar),
-          }),
+          on:
+            _m1 ||
+            ($ctx._m1 = {
+              click: api_bind($cmp.onClickBar),
+            }),
           ref: "bar",
           style: $cmp.barStyle,
           attrs: {