fix(integration-karma): disable_synthetic is not an exported option #2554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekashida
approved these changes
Oct 28, 2021
| @@ -111,7 +111,7 @@ function getSauceConfig() { | |||
| customData: { | |||
| lwc: { | |||
| COMPAT, | |||
| DISABLE_SYNTHETIC, | |||
| DISABLE_SYNTHETIC: !SYNTHETIC_SHADOW_ENABLED, | |||
There was a problem hiding this comment.
I always wonder what this is used for.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes an issue introduced in #2496:
DISABLE_SYNTHETICwas removed in favor ofSYNTHETIC_SHADOW_ENABLEDand is no longer an exported option.Note: The effect of
DISABLE_SYNTHETICbeing alwaysundefinedwas not observable becausecompatandnativeShadowCompatibleare opposed (ifcompat=truethennativeShadowCompatible=false, and vice versa), at least for the configured browsers.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?