Support for Kibana requests #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 29, 2014 13:48
"Access-Control-Allow-Headers" to make it work with Kibana In 'AllPermsRealm' class, replaced System.outs with log.debug statements
milestone. Kibana uses a generic search query such as
http://elasticsearchhost:9200/testindex1/_search. To provide security
around queries like that, the pulgin is modfied to support addtional
kibana configuration. Configuration is as follows.
PUT /securityconfiguration/actionpathfilter/kibana
{
"rules": [
{
"index" : "testindex1",
"types" : [ "testtype1", "testtype5", "testtype13",
"testtype7"]
},
{
"index" : "testindex2",
"types" : [ "testtype19", "testtype21" ]
},
{
"index" : "testdata",
"types" : [ ""testtype1", "testtype2" ]
}
]
}
This configuration allows users to specify which types in a given index
are accessible by users.
In 'TomcatHttpServerRestRequest' class, removed final on 'content'
variable. This is done to enable the ES request modification on the fly
so that kibana security can be applied.
In 'SecurityService' class added getKibanaTypes method to obtain the
types that are accessible in a given index.
In 'ActionPathFilter' class added 'massageKibanaRequest' method to add
'types' filters to Kibana requests. Kibana 3.0.0 uses one index at a
time. So the methtod supports one index at a time. In this method, for
all the types are evaluated against core plugins access permissions. If
the permission evaluation for the type return true, then that type is
added as a filter to narrow down the search query.
|
thanks, will review and merge soon |
|
👍 |
|
Just wondering, will this still be merged? |
|
will merge, stay tuned |
salyh
pushed a commit
that referenced
this pull request
Jul 23, 2014
|
Start working on this here 46b8032 |
|
done with 19070c3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Kibana requests added.