Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Remove to remove an item from a slice #180

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MarkRosemaker
Copy link

This PR adds a function to remove an element from a slice.

h/t to https://yourbasic.org/golang/delete-element-slice/

@codecov-commenter
Copy link

Codecov Report

Merging #180 (95bf3bc) into master (c9f230d) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
+ Coverage   90.36%   90.43%   +0.07%     
==========================================
  Files          13       13              
  Lines        1495     1506      +11     
==========================================
+ Hits         1351     1362      +11     
  Misses        141      141              
  Partials        3        3              
Flag Coverage Δ
unittests 90.43% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
slice.go 98.19% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9f230d...95bf3bc. Read the comment docs.

@samber
Copy link
Owner

samber commented Jul 24, 2022

Hi @MarkRosemaker and thanks for your first contribution.

Could you please return a new slice instead of modifying the collection?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants