Skip to content

Commit

Permalink
execute task directly instead of going through runEventLoopTick (face…
Browse files Browse the repository at this point in the history
…book#46540)

Summary:
Pull Request resolved: facebook#46540

changelog: [internal]

avoid calling `runEventLoopTick` and execute task directly. runEventLoopTick is not designed to be called on re-entries.

Reviewed By: rubennorte

Differential Revision: D62871782
  • Loading branch information
sammy-SC authored and facebook-github-bot committed Sep 18, 2024
1 parent 4b035d8 commit 091b35c
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ void RuntimeScheduler_Modern::executeNowOnTheSameThread(
// Protecting against re-entry into `executeNowOnTheSameThread` from within
// `executeNowOnTheSameThread`. Without accounting for re-rentry, a deadlock
// will occur when trying to gain access to the runtime.
return runEventLoopTick(*runtimePtr, task, currentTime);
return executeTask(*runtimePtr, task, true);
}

syncTaskRequests_++;
Expand Down

0 comments on commit 091b35c

Please sign in to comment.