Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend 1bp SEQ with QUAL="*" as quality-unavailable. #752

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jkbonfield
Copy link
Contributor

The change is simply a footnote indicating the presence of the ambiguity and a mild recommendation, however it's not likely to make any practical difference in real-world data where even if 1bp reads exist their quality values aren't likely to be a deciding factor over their validity.

Also in attempting to build the SAM spec my latex blew up. This turns out to be due to #670 which added use of \> for non-breaking space. Our systems here are pretty old, and latex couldn't cope with that. However in the interests of keeping the spec as easy to build as possible, I did a trivial replacement in its own commit.

The use of \textsc{cr\>lf} breaks pdfTeX 3.14159265-2.6-1.40.18.
Switching to \textsc{cr\,lf} cures it.  Visually they're almost
identical and it's only a footnote anyway.
"*" is either QUAL 9, or QUAL unavailable.  Made a recommendation in
a footnote, mainly as an indication that the ambiguity exists.  In
practice it's vanishingly unlikely to matter.

Fixes samtools#715
@jkbonfield jkbonfield added the sam label Jan 29, 2024
Copy link

Changed PDFs as of a8550ef: SAMv1 (diff).

github-actions bot pushed a commit that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

2 participants