Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow sub-collections to be created from collection page #5580

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Conversation

blancoj
Copy link
Contributor

@blancoj blancoj commented Mar 25, 2022

Fixes #5492

When in a collection page, the user should be able to create a sub-collection.

The reason this was not working was because the code was checking for a nil value for child, but if there is no child the value to check for is false. The false value is set here in the code:

https://github.com/samvera/hyrax/blob/main/app/forms/hyrax/forms/dashboard/nest_collection_form.rb#L33

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • Go to collection editing page.
  • Clicking "Create new collection as subcollection"
  • You should be able to create the new sub-collection.
  • Go back to the collection page and you should see the newly created sub-collection displayed on this page.

@samvera/hyrax-code-reviewers

Copy link
Contributor

@elrayle elrayle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix.

@elrayle elrayle merged commit 03b3cd9 into main Mar 28, 2022
@elrayle elrayle deleted the issue-5492 branch March 28, 2022 18:33
@dlpierce dlpierce added the notes-bugfix Release Notes: Fixed a bug label Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-bugfix Release Notes: Fixed a bug
Projects
None yet
3 participants