Add Ukrainian language #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lykahb
commented
Sep 25, 2024
| @@ -11,7 +11,7 @@ | |||
| class Lang(Observable): | |||
| observers = [] | |||
| callbacks = [] | |||
| FONTS = {"jp": "NotoSansJP-Regular.otf", "tr": "NotoSans-Regular.ttf"} | |||
| FONTS = {"jp": "NotoSansJP-Regular.otf", "tr": "NotoSans-Regular.ttf", "ua": "NotoSans-Regular.ttf"} | |||
There was a problem hiding this comment.
The default font didn't display several letters.
| @@ -920,7 +920,7 @@ msgstr "{num} available katago versions found" | |||
| msgid "All models downloaded" | |||
| msgstr "All available models already downloaded" | |||
|
|
|||
| #. error message on trying to download models when already done | |||
| #. error message on trying to download katago when already done | |||
There was a problem hiding this comment.
Drive-by improvements
|
Thanks! Looks good, except maybe the jigo text on the graph is a little long (does it really need a parenthesized label?). |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I verified that the text fits the dimensions of the UI elements.
I'd also like to do a follow-up PR that localizes a few more elements that are hardcoded now - the B/W on the chart and the AI thoughts.