Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capytaine v2 Hydrostatics #284

Merged
merged 22 commits into from
Oct 26, 2023

Conversation

jtgrasb
Copy link
Collaborator

@jtgrasb jtgrasb commented Oct 25, 2023

Description

This PR updates wecopttool to use Capytaine to compute the hydrostatics and store them as part of the bem data. This removes the hydrostatics.py script.

Type of PR

  • Bug fix
  • New feature
  • Documentation
  • Other: (specify)

Checklist for PR

Additional details

A few notes:

  • Changed linear_hydrodynamics to just compute friction now.
  • Added xarray import to tutorial 3 and 4 for creating inertia matrix manually
    Tutorials:
  • 3 is working, but slightly different because I am now feeding the density into run_bem()
  • 4 is working, but slightly different because stiffness is now slightly different. I haven't figured out why yet.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6645498044

  • 64 of 72 (88.89%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 91.93%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/test_integration.py 15 17 88.24%
wecopttool/core.py 45 51 88.24%
Files with Coverage Reduction New Missed Lines %
wecopttool/core.py 1 91.49%
Totals Coverage Status
Change from base Build 6536704021: -0.5%
Covered Lines: 2358
Relevant Lines: 2565

💛 - Coveralls

Copy link
Member

@cmichelenstrofer cmichelenstrofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not review the tests or tutorials yet. This is looking good! But there are several small changes I suggest + some merging errors (seems like you are overriding some recent PRs). See comments.

wecopttool/core.py Outdated Show resolved Hide resolved
wecopttool/core.py Outdated Show resolved Hide resolved
wecopttool/core.py Outdated Show resolved Hide resolved
wecopttool/core.py Outdated Show resolved Hide resolved
wecopttool/core.py Outdated Show resolved Hide resolved
wecopttool/core.py Outdated Show resolved Hide resolved
wecopttool/core.py Outdated Show resolved Hide resolved
wecopttool/core.py Outdated Show resolved Hide resolved
wecopttool/core.py Outdated Show resolved Hide resolved
wecopttool/core.py Outdated Show resolved Hide resolved
jtgrasb and others added 15 commits October 26, 2023 16:45
Co-authored-by: Carlos A. Michelén Ströfer <c.michelen.strofer@gmail.com>
Co-authored-by: Carlos A. Michelén Ströfer <c.michelen.strofer@gmail.com>
Co-authored-by: Carlos A. Michelén Ströfer <c.michelen.strofer@gmail.com>
Co-authored-by: Carlos A. Michelén Ströfer <c.michelen.strofer@gmail.com>
Co-authored-by: Carlos A. Michelén Ströfer <c.michelen.strofer@gmail.com>
Co-authored-by: Carlos A. Michelén Ströfer <c.michelen.strofer@gmail.com>
Co-authored-by: Carlos A. Michelén Ströfer <c.michelen.strofer@gmail.com>
Co-authored-by: Carlos A. Michelén Ströfer <c.michelen.strofer@gmail.com>
wecopttool/core.py Outdated Show resolved Hide resolved
wecopttool/core.py Outdated Show resolved Hide resolved
wecopttool/core.py Outdated Show resolved Hide resolved
wecopttool/core.py Outdated Show resolved Hide resolved
wecopttool/core.py Outdated Show resolved Hide resolved
@cmichelenstrofer cmichelenstrofer merged commit 8d383e3 into sandialabs:main Oct 26, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants