Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update waves.py for nfreq=1 #312

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Update waves.py for nfreq=1 #312

merged 2 commits into from
Jan 25, 2024

Conversation

jtgrasb
Copy link
Collaborator

@jtgrasb jtgrasb commented Jan 5, 2024

Description

This pull request allows for waves to be set up with nfreq = 1 without producing errors to resolve #308.

Type of PR

  • Bug fix

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7423551248

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 94.058%

Totals Coverage Status
Change from base Build 7135291663: 0.08%
Covered Lines: 2501
Relevant Lines: 2659

💛 - Coveralls

@jtgrasb jtgrasb marked this pull request as draft January 9, 2024 16:04
Remove line that selects item() of degrees_to_radians
@jtgrasb
Copy link
Collaborator Author

jtgrasb commented Jan 11, 2024

I've removed the lines

if radians.size == 1: radians = radians.item()

from the degrees_to_radians() function. There doesn't seem to be a reason for this line. It seems to make the result of degrees_to_radians() 1-dimensional, but it doesn't seem to actually affect any results.

@jtgrasb jtgrasb marked this pull request as ready for review January 12, 2024 22:04
@jtgrasb jtgrasb merged commit 528c679 into sandialabs:main Jan 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: error creating wave if nfreq=1
2 participants