Do not mutate type stack (microsoft#4299)

sarangan12 · Sep 16, 2024 · 1cee1b7 · 1cee1b7
1 parent c5773e6
commit 1cee1b7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.chronus/changes/fix-type-stack-mutate-2024-7-29-13-18-20.md b/.chronus/changes/fix-type-stack-mutate-2024-7-29-13-18-20.md
@@ -0,0 +1,6 @@
+---
+changeKind: internal
+packages:
+  - "@typespec/versioning"
+---
+
diff --git a/packages/versioning/src/validate.ts b/packages/versioning/src/validate.ts
@@ -566,8 +566,7 @@ function getAvailabilityMapFromStack(
   program: Program,
   typeStack: Type[]
 ): Map<string, Availability> | undefined {
-  let type;
-  while ((type = typeStack.shift())) {
+  for (const type of typeStack) {
     const map = getAvailabilityMap(program, type);
     if (map) {
       return map;