Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the missing version bound #235

Merged
merged 2 commits into from
May 12, 2020
Merged

Add the missing version bound #235

merged 2 commits into from
May 12, 2020

Conversation

frostming
Copy link
Member

This PR makes the parsing more robust by adding the missing version bound for 1.x.

Fix #234

techalchemy
techalchemy approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@techalchemy techalchemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, there was a python 1.x... thanks!

@techalchemy
Copy link
Member

will wait on tests and then merge

@techalchemy techalchemy merged commit 148f564 into master May 12, 2020
@techalchemy techalchemy deleted the bugfix/234 branch May 12, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techalchemy techalchemy techalchemy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Old Python specifiers can't be parsed correctly
2 participants
@frostming @techalchemy