Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add required arg backtrack_causes to get_preferences() override #136

Merged
merged 2 commits into from
Oct 1, 2023

Conversation

jimkring
Copy link
Contributor

backtrack_causes is a required argument in get_preferences, as defined by the parent class resolvelib.AbstractProvider. Adding this argument allows the example to run without errors.

backtrack_causes is a required argument in get_preferences, as defined by the parent class resolvelib.AbstractProvider. Adding this argument allows the example to run without errors.
@jimkring
Copy link
Contributor Author

not sure why CI / Lint failed. nox/black check works for me :)

@frostming
Copy link
Member

not sure why CI / Lint failed. nox/black check works for me :)

It complains because the line should be broken into one argument per line

Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add a CI job to ensure the demo runs

@pradyunsg pradyunsg merged commit 6df10d7 into sarugaku:main Oct 1, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants