Remove dead code in the extension store #2129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sources
Map will never containextension.extender
as it is anExtender
object, not a ComplexSelector.I updated that by assuming that the comment just above it is true and that the selector should actually be removed.
An alternative could be to remove that line of code entirely, preserving the current behavior where nothing is removed.
The dart compiler does not catch this mistake as
Map.remove
allows passing any object, not just objects matching the key type.I caught this when porting that code to PHP for the Scssphp project, where phpstan (the PHP static analyzer we use) has a different signature for the storage we use, requiring a valid key type.